Remove the checking of "redirecting to the same url", backport #917

Author: slandelle

src/main/java/com/ning/http/client/providers/netty/handler/Protocol.java

@@ -117,67 +117,65 @@ protected boolean exitAfterHandlingRedirect(//
                 // We must allow 401 handling again.
                 future.getAndSetAuth(false);
 
+                String originalMethod = request.getMethod();
+                boolean switchToGet = !originalMethod.equals("GET")
+                        && (statusCode == 303 || (statusCode == 302 && !config.isStrict302Handling()));
+
+                final RequestBuilder requestBuilder = new RequestBuilder(switchToGet ? "GET" : originalMethod)//
+                        .setCookies(request.getCookies())//
+                        .setConnectionPoolKeyStrategy(request.getConnectionPoolPartitioning())//
+                        .setFollowRedirects(true)//
+                        .setLocalInetAddress(request.getLocalAddress())//
+                        .setNameResolver(request.getNameResolver())//
+                        .setProxyServer(request.getProxyServer())//
+                        .setRealm(request.getRealm())//
+                        .setRequestTimeout(request.getRequestTimeout())//
+                        .setVirtualHost(request.getVirtualHost());
+
+                requestBuilder.setHeaders(propagatedHeaders(request, realm, switchToGet));
+
+                // in case of a redirect from HTTP to HTTPS, future attributes might change
+                final boolean initialConnectionKeepAlive = future.isKeepAlive();
+                final Object initialPartitionKey = future.getPartitionKey();
+
                 HttpHeaders responseHeaders = response.headers();
                 String location = responseHeaders.get(HttpHeaders.Names.LOCATION);
                 Uri uri = Uri.create(future.getUri(), location);
+                future.setUri(uri);
+                String newUrl = uri.toUrl();
+                if (request.getUri().getScheme().startsWith(WEBSOCKET)) {
+                    newUrl = newUrl.replaceFirst(HTTP, WEBSOCKET);
+                }
 
-                if (!uri.equals(future.getUri())) {
-                    String originalMethod = request.getMethod();
-                    boolean switchToGet = !originalMethod.equals("GET") && (statusCode == 303 || (statusCode == 302 && !config.isStrict302Handling()));
-
-                    final RequestBuilder requestBuilder = new RequestBuilder(switchToGet ? "GET" : originalMethod)//
-                            .setCookies(request.getCookies())//
-                            .setConnectionPoolKeyStrategy(request.getConnectionPoolPartitioning())//
-                            .setFollowRedirects(true)//
-                            .setLocalInetAddress(request.getLocalAddress())//
-                            .setNameResolver(request.getNameResolver())//
-                            .setProxyServer(request.getProxyServer())//
-                            .setRealm(request.getRealm())//
-                            .setRequestTimeout(request.getRequestTimeout())//
-                            .setVirtualHost(request.getVirtualHost());
-
-                    requestBuilder.setHeaders(propagatedHeaders(request, realm, switchToGet));
-
-                    // in case of a redirect from HTTP to HTTPS, future attributes might change
-                    final boolean initialConnectionKeepAlive = future.isKeepAlive();
-                    final Object initialPartitionKey = future.getPartitionKey();
-
-                    future.setUri(uri);
-                    String newUrl = uri.toUrl();
-                    if (request.getUri().getScheme().startsWith(WEBSOCKET)) {
-                        newUrl = newUrl.replaceFirst(HTTP, WEBSOCKET);
-                    }
-
-                    logger.debug("Redirecting to {}", newUrl);
+                logger.debug("Redirecting to {}", newUrl);
 
-                    for (String cookieStr : responseHeaders.getAll(HttpHeaders.Names.SET_COOKIE)) {
-                        Cookie c = CookieDecoder.decode(cookieStr);
-                        if (c != null)
-                            requestBuilder.addOrReplaceCookie(c);
-                    }
-
-                    requestBuilder.setHeaders(propagatedHeaders(future.getRequest(), realm, switchToGet));
+                for (String cookieStr : responseHeaders.getAll(HttpHeaders.Names.SET_COOKIE)) {
+                    Cookie c = CookieDecoder.decode(cookieStr);
+                    if (c != null)
+                        requestBuilder.addOrReplaceCookie(c);
+                }
 
-                    final Request nextRequest = requestBuilder.setUrl(newUrl).build();
+                requestBuilder.setHeaders(propagatedHeaders(future.getRequest(), realm, switchToGet));
 
-                    logger.debug("Sending redirect to {}", request.getUri());
+                final Request nextRequest = requestBuilder.setUrl(newUrl).build();
 
-                    if (future.isKeepAlive() && !HttpHeaders.isTransferEncodingChunked(response) && !response.isChunked()) {
+                logger.debug("Sending redirect to {}", request.getUri());
 
-                        if (isSameHostAndProtocol(request.getUri(), nextRequest.getUri())) {
-                            future.setReuseChannel(true);
-                        } else {
-                            channelManager.drainChannelAndOffer(channel, future, initialConnectionKeepAlive, initialPartitionKey);
-                        }
+                if (future.isKeepAlive() && !HttpHeaders.isTransferEncodingChunked(response) && !response.isChunked()) {
 
+                    if (isSameHostAndProtocol(request.getUri(), nextRequest.getUri())) {
+                        future.setReuseChannel(true);
                     } else {
-                        // redirect + chunking = WAT
-                        channelManager.closeChannel(channel);
+                        channelManager.drainChannelAndOffer(channel, future, initialConnectionKeepAlive, initialPartitionKey);
                     }
 
-                    requestSender.sendNextRequest(nextRequest, future);
-                    return true;
+                } else {
+                    // redirect + chunking = WAT
+                    channelManager.closeChannel(channel);
                 }
+
+                requestSender.sendNextRequest(nextRequest, future);
+                return true;
             }
         }
         return false;