Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: MaTriXy/async-http-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 14ee30a
Choose a base ref
...
head repository: AsyncHttpClient/async-http-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 41b1eec
Choose a head ref
  • 4 commits
  • 9 files changed
  • 5 contributors

Commits on May 9, 2025

  1. Fix NPE race in NettyResponseFuture.cancel (AsyncHttpClient#2042) (As…

    …yncHttpClient#2088)
    
    Fixes AsyncHttpClient#2042 
    
    This is a typical TOCTOU (time-of-check/time-of-use) race
    https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use.
    The NPE was occurring because the channel field could be set to null by
    another thread between the check and its use:
    
    if (channel != null) {                 // time-of-check
        Channels.setDiscard(channel);      //  time-of-use
        Channels.silentlyCloseChannel(channel);
    }
    
    By copying channel into a local variable in one atomic read, we ensure
    that—even if another thread changes the field—the local reference
    remains valid.
    
    P.S. It is hard to write a deterministic test that fails consistently,
    so this PR only includes the code fix.
    
    ---------
    
    Co-authored-by: prat <[email protected]>
    pratt4 and prat authored May 9, 2025
    Configuration menu
    Copy the full SHA
    73911eb View commit details
    Browse the repository at this point in the history

Commits on May 10, 2025

  1. Configuration menu
    Copy the full SHA
    6ac1ccc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb50dc2 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2025

  1. Bump org.apache.tomcat.embed:tomcat-embed-core from 10.1.39 to 10.1.4…

    …0 in /client (AsyncHttpClient#2092)
    
    Bumps org.apache.tomcat.embed:tomcat-embed-core from 10.1.39 to 10.1.40.
    
    
    [![Dependabot compatibility
    score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.tomcat.embed:tomcat-embed-core&package-manager=maven&previous-version=10.1.39&new-version=10.1.40)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't
    alter it yourself. You can also trigger a rebase manually by commenting
    `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits
    that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after
    your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge
    and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating
    it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all
    of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop
    Dependabot creating any more for this major version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop
    Dependabot creating any more for this minor version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop
    Dependabot creating any more for this dependency (unless you reopen the
    PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the
    [Security Alerts
    page](https://github.com/AsyncHttpClient/async-http-client/network/alerts).
    
    </details>
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored May 18, 2025
    Configuration menu
    Copy the full SHA
    41b1eec View commit details
    Browse the repository at this point in the history
Loading