Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: AsyncHttpClient/async-http-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: async-http-client-project-3.0.2
Choose a base ref
...
head repository: AsyncHttpClient/async-http-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 4 commits
  • 8 files changed
  • 5 contributors

Commits on Apr 2, 2025

  1. Configuration menu
    Copy the full SHA
    14ee30a View commit details
    Browse the repository at this point in the history

Commits on May 9, 2025

  1. Fix NPE race in NettyResponseFuture.cancel (#2042) (#2088)

    Fixes #2042 
    
    This is a typical TOCTOU (time-of-check/time-of-use) race
    https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use.
    The NPE was occurring because the channel field could be set to null by
    another thread between the check and its use:
    
    if (channel != null) {                 // time-of-check
        Channels.setDiscard(channel);      //  time-of-use
        Channels.silentlyCloseChannel(channel);
    }
    
    By copying channel into a local variable in one atomic read, we ensure
    that—even if another thread changes the field—the local reference
    remains valid.
    
    P.S. It is hard to write a deterministic test that fails consistently,
    so this PR only includes the code fix.
    
    ---------
    
    Co-authored-by: prat <[email protected]>
    pratt4 and prat authored May 9, 2025
    Configuration menu
    Copy the full SHA
    73911eb View commit details
    Browse the repository at this point in the history

Commits on May 10, 2025

  1. Add japicmp (#2091)

    hyperxpro authored May 10, 2025
    Configuration menu
    Copy the full SHA
    6ac1ccc View commit details
    Browse the repository at this point in the history
  2. Feature: Add Option to Strip Authorization Header on Redirect (#2090)

    Closes #1884
    
    ---------
    
    Co-authored-by: Copilot <[email protected]>
    hyperxpro and Copilot authored May 10, 2025
    Configuration menu
    Copy the full SHA
    fb50dc2 View commit details
    Browse the repository at this point in the history
Loading