NettyAsyncHttpProvider doesn't check if USE_BLOCKING_IO is true or false, only if not null

[bric3]

At the following line

https://github.com/AsyncHttpClient/async-http-client/blob/master/providers/netty/src/main/java/com/ning/http/client/providers/netty/NettyAsyncHttpProvider.java#L191

if (asyncHttpProviderConfig.getProperty(NettyAsyncHttpProviderConfig.USE_BLOCKING_IO) != null) {
  socketChannelFactory = new OioClientSocketChannelFactory(config.executorService());
} else {

The provider should check if the value is true or false, not if the value is present.

[slandelle]

@jfarcand Mind if I break NettyAsyncHttpProviderConfig in master/A.8 and make it a proper POJO instead of a non type safe wrapper on top of Map<String, Object>?

[bric3]

I second that change, but other providers should be changed the same way.

[jfarcand]

+1

[slandelle]

Grizzly provider use a enum, no sure if it's worth breaking it to make it consistent.
By the way, I passed the properties to all bootstraps in configureNetty.