Skip to content

Commit 01835a9

Browse files
authored
Merge pull request #2 from daniel-stoneuk/master
Fix fragment container view crash and switchmap import
2 parents b094b68 + 76003a8 commit 01835a9

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

app/src/main/java/guide/graphql/toc/MainActivity.kt

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,29 +2,37 @@ package guide.graphql.toc
22

33
import android.os.Bundle
44
import androidx.appcompat.app.AppCompatActivity
5-
import androidx.navigation.findNavController
5+
import androidx.navigation.NavController
6+
import androidx.navigation.fragment.NavHostFragment
67
import androidx.navigation.ui.NavigationUI
78
import guide.graphql.toc.databinding.ActivityMainBinding
89

10+
911
class MainActivity : AppCompatActivity() {
1012

1113
private lateinit var binding: ActivityMainBinding
14+
private lateinit var navController: NavController
1215

1316
override fun onCreate(savedInstanceState: Bundle?) {
1417
super.onCreate(savedInstanceState)
1518

1619
binding = ActivityMainBinding.inflate(layoutInflater)
1720

21+
val navHostFragment = supportFragmentManager
22+
.findFragmentById(R.id.nav_host_fragment) as NavHostFragment?
23+
24+
navController = navHostFragment!!.navController
25+
1826
setContentView(binding.root)
1927
setSupportActionBar(binding.toolbar)
2028

2129
NavigationUI.setupActionBarWithNavController(
2230
this,
23-
findNavController(R.id.nav_host_fragment)
31+
navController
2432
)
2533
}
2634

2735
override fun onSupportNavigateUp(): Boolean {
28-
return findNavController(R.id.nav_host_fragment).navigateUp() || super.onSupportNavigateUp()
36+
return navController.navigateUp() || super.onSupportNavigateUp()
2937
}
3038
}

app/src/main/java/guide/graphql/toc/ui/chapters/ChaptersViewModel.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package guide.graphql.toc.ui.chapters
22

33
import android.util.Log
44
import androidx.lifecycle.LiveData
5-
import androidx.lifecycle.MutableLiveData
65
import androidx.lifecycle.ViewModel
76
import androidx.lifecycle.liveData
87
import com.apollographql.apollo.coroutines.toDeferred
@@ -13,8 +12,6 @@ import guide.graphql.toc.apolloClient
1312

1413
class ChaptersViewModel : ViewModel() {
1514

16-
val bookId: LiveData<Int> = MutableLiveData(0)
17-
1815
val chapterList: LiveData<Resource<List<ChaptersQuery.Chapter>>> = liveData {
1916
emit(Resource.loading(null))
2017
try {

app/src/main/java/guide/graphql/toc/ui/sections/SectionsViewModel.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
package guide.graphql.toc.ui.sections
22

33
import android.util.Log
4-
import androidx.lifecycle.LiveData
5-
import androidx.lifecycle.MutableLiveData
6-
import androidx.lifecycle.ViewModel
4+
import androidx.lifecycle.*
75
import com.apollographql.apollo.coroutines.toDeferred
86
import com.apollographql.apollo.exception.ApolloException
97
import guide.graphql.toc.Resource

app/src/main/res/layout/activity_main.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
android:theme="@style/AppTheme.Toolbar" />
2424
</com.google.android.material.appbar.AppBarLayout>
2525

26-
<fragment
26+
<androidx.fragment.app.FragmentContainerView
2727
android:id="@+id/nav_host_fragment"
2828
android:name="androidx.navigation.fragment.NavHostFragment"
2929
android:layout_width="match_parent"

0 commit comments

Comments
 (0)