Improve adapter constructors

Author: daniel-stoneuk

app/src/main/java/guide/graphql/toc/ui/chapters/ChaptersAdapter.kt

@@ -10,8 +10,8 @@ import guide.graphql.toc.R
 import guide.graphql.toc.databinding.ChapterBinding
 
 class ChaptersAdapter(
-    private var chapters: List<ChaptersQuery.Chapter>,
     private val context: Context,
+    private var chapters: List<ChaptersQuery.Chapter> = listOf(),
     private val onItemClicked: ((ChaptersQuery.Chapter) -> Unit)
 ) :
     RecyclerView.Adapter<ChaptersAdapter.ViewHolder>() {

app/src/main/java/guide/graphql/toc/ui/chapters/ChaptersFragment.kt

@@ -45,7 +45,6 @@ class ChaptersFragment : Fragment() {
         requireActivity()
         val adapter =
             ChaptersAdapter(
-                listOf(),
                 requireContext()
             ) { chapter ->
                 findNavController().navigate(

app/src/main/java/guide/graphql/toc/ui/sections/SectionsAdapter.kt

@@ -9,9 +9,9 @@ import guide.graphql.toc.SectionsQuery
 import guide.graphql.toc.databinding.SectionBinding
 
 class SectionsAdapter(
-    private val chapterNumber: Int?,
-    private var sections: List<SectionsQuery.Section?>,
-    private val context: Context
+    private val context: Context,
+    private val chapterNumber: Int,
+    private var sections: List<SectionsQuery.Section?> = listOf()
 ) :
     RecyclerView.Adapter<SectionsAdapter.ViewHolder>() {
 

app/src/main/java/guide/graphql/toc/ui/sections/SectionsFragment.kt

@@ -46,27 +46,11 @@ class SectionsFragment : Fragment() {
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
-//        val activity = (requireActivity() as AppCompatActivity)
-//        activity.setSupportActionBar(binding.chapterHeader)
-//        activity.supportActionBar?.setDisplayHomeAsUpEnabled(true)
-//
-//        binding.chapterHeader.setNavigationOnClickListener {
-//            findNavController().navigateUp()
-//        }
-//
-//        binding.chapterHeader.setNavigationIcon(R.drawable.ic_baseline_arrow_back_24)
-//        activity.title =
-//            if (args.chapterNumber == -1) args.chapterTitle else getString(
-//                R.string.chapter_title,
-//                args.chapterNumber.toString(),
-//                args.chapterTitle
-//            )
 
         val adapter =
             SectionsAdapter(
-                args.chapterNumber,
-                listOf(),
-                requireContext()
+                requireContext(),
+                args.chapterNumber
             )
         val layoutManager = LinearLayoutManager(requireContext())
         binding.sections.layoutManager = layoutManager