feat(oninit): moved logic parts from constructors to ngOnInit method

Author: Ismaestro

src/app/app.component.ts

@@ -1,7 +1,6 @@
-import {Component} from '@angular/core';
+import {Component, OnInit} from '@angular/core';
 import {TranslateService} from '@ngx-translate/core';
 import {Meta, Title} from '@angular/platform-browser';
-
 import {NavigationEnd, Router} from '@angular/router';
 import {AppConfig} from './config/app.config';
 import {MatSnackBar} from '@angular/material';
@@ -13,17 +12,19 @@ declare const Modernizr;
   templateUrl: './app.component.html'
 })
 
-export class AppComponent {
+export class AppComponent implements OnInit {
 
-  isOnline = navigator.onLine;
+  isOnline: boolean;
 
   constructor(private translateService: TranslateService,
               private title: Title,
               private meta: Meta,
               private snackBar: MatSnackBar,
               private router: Router) {
+    this.isOnline = navigator.onLine;
+  }
 
-    this.translateService = translateService;
+  ngOnInit() {
     this.translateService.setDefaultLang('en');
     this.translateService.use('en');
 

src/app/core/footer/footer.component.ts

@@ -8,10 +8,12 @@ import {TranslateService} from '@ngx-translate/core';
 })
 
 export class FooterComponent {
+
   currentLang: string;
-  currentDate = Date.now();
+  currentDate: number;
 
   constructor(private translateService: TranslateService) {
     this.currentLang = this.translateService.currentLang;
+    this.currentDate = Date.now();
   }
 }

src/app/core/nav/nav.component.ts

@@ -1,4 +1,4 @@
-import {Component, Inject} from '@angular/core';
+import {Component, Inject, OnInit} from '@angular/core';
 import {TranslateService} from '@ngx-translate/core';
 
 import {APP_CONFIG, AppConfig} from '../../config/app.config';
@@ -11,7 +11,8 @@ import {ProgressBarService} from '../progress-bar.service';
   styleUrls: ['./nav.component.scss']
 })
 
-export class NavComponent {
+export class NavComponent implements OnInit {
+
   appConfig: any;
   menuItems: any[];
   progressBarMode: string;
@@ -21,9 +22,11 @@ export class NavComponent {
               private progressBarService: ProgressBarService,
               private translateService: TranslateService) {
     this.appConfig = appConfig;
-    this.loadMenus();
     this.currentLang = this.translateService.currentLang;
+  }
 
+  ngOnInit() {
+    this.loadMenus();
     this.progressBarService.updateProgressBar$.subscribe((mode: string) => {
       this.progressBarMode = mode;
     });

src/app/core/search-bar/search-bar.component.ts

@@ -1,4 +1,4 @@
-import {Component} from '@angular/core';
+import {Component, OnInit} from '@angular/core';
 import {LoggerService} from '../logger.service';
 import {Hero} from '../../heroes/shared/hero.model';
 import {FormControl} from '@angular/forms';
@@ -15,16 +15,19 @@ import {AppConfig} from '../../config/app.config';
   ]
 })
 
-export class SearchBarComponent {
-  defaultHeroes: Array<Hero> = [];
+export class SearchBarComponent implements OnInit {
+
+  defaultHeroes: Array<Hero>;
   heroFormControl: FormControl;
   filteredHeroes: any;
-  heroesAutocomplete: any;
 
   constructor(private heroService: HeroService,
               private router: Router) {
+    this.defaultHeroes = [];
     this.heroFormControl = new FormControl();
+  }
 
+  ngOnInit() {
     this.heroService.getAllHeroes().subscribe((heroes: Array<Hero>) => {
       this.defaultHeroes = heroes.filter(hero => hero['default']);
 

src/app/heroes/hero-detail/hero-detail.component.ts

@@ -1,4 +1,4 @@
-import {Component} from '@angular/core';
+import {Component, OnInit} from '@angular/core';
 import {Hero} from '../shared/hero.model';
 import {HeroService} from '../shared/hero.service';
 import {ActivatedRoute} from '@angular/router';
@@ -9,12 +9,16 @@ import {ActivatedRoute} from '@angular/router';
   styleUrls: ['./hero-detail.component.scss']
 })
 
-export class HeroDetailComponent {
+export class HeroDetailComponent implements OnInit {
+
   hero: Hero;
   canVote: boolean;
 
   constructor(private heroService: HeroService,
               private activatedRoute: ActivatedRoute) {
+  }
+
+  ngOnInit() {
     this.activatedRoute.params.subscribe((params: any) => {
       if (params['id']) {
         this.heroService.getHeroById(params['id']).subscribe((hero: Hero) => {

src/app/heroes/hero-list/hero-list.component.ts

@@ -1,4 +1,4 @@
-import {Component, ViewChild} from '@angular/core';
+import {Component, OnInit, ViewChild} from '@angular/core';
 import {Hero} from '../shared/hero.model';
 import {HeroService} from '../shared/hero.service';
 import {FormBuilder, FormGroup, Validators} from '@angular/forms';
@@ -23,7 +23,8 @@ export class RemoveHeroDialogComponent {
   styleUrls: ['./hero-list.component.scss']
 })
 
-export class HeroListComponent {
+export class HeroListComponent implements OnInit {
+
   heroes: Hero[];
   newHeroForm: FormGroup;
   canVote = false;
@@ -40,7 +41,9 @@ export class HeroListComponent {
       'name': ['', [Validators.required]],
       'alterEgo': ['', [Validators.required]]
     });
+  }
 
+  ngOnInit() {
     this.heroService.getAllHeroes().subscribe((heroes: Array<Hero>) => {
       this.heroes = heroes.sort((a, b) => {
         return b.likes - a.likes;

src/app/heroes/hero-top/hero-top.component.ts

@@ -1,4 +1,4 @@
-import {Component} from '@angular/core';
+import {Component, OnInit} from '@angular/core';
 import {Hero} from '../shared/hero.model';
 import {HeroService} from '../shared/hero.service';
 import {AppConfig} from '../../config/app.config';
@@ -9,15 +9,17 @@ import {Router} from '@angular/router';
   templateUrl: './hero-top.component.html',
   styleUrls: ['./hero-top.component.scss']
 })
-export class HeroTopComponent {
+export class HeroTopComponent implements OnInit {
 
   heroes: Hero[] = null;
   canVote = false;
 
   constructor(private heroService: HeroService,
               private router: Router) {
     this.canVote = this.heroService.checkIfUserCanVote();
+  }
 
+  ngOnInit() {
     this.heroService.getAllHeroes().subscribe((heroes) => {
       this.heroes = heroes.sort((a, b) => {
         return b.likes - a.likes;