Skip to content

Commit 45281ff

Browse files
Ismael Ramosiramos
authored andcommitted
feat(readme): update angular version and warning
1 parent b17bf23 commit 45281ff

File tree

2 files changed

+21
-21
lines changed

2 files changed

+21
-21
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<h3 align="center">Angular Example App</h3>
77

88
<p align="center">
9-
Example app with Angular 7 + Angular CLI + Angular Universal + i18n + Firebase
9+
Example app with Angular 8 + Angular CLI + Angular Universal + i18n + Firebase
1010
<br>
1111
<br>
1212
:clap::clap::tada::tada::tada::tada::clap::clap:
@@ -96,9 +96,9 @@ This repo is using Firebase. We use Cloud Firestore and Cloud Storage to handle
9696

9797
## Quick start
9898

99-
**Warning**
99+
<span style="color:red">**WARNING**</span>
100100

101-
> Verify that you are running at least node 8.9.x and npm 5.x.x by running node -v and npm -v in a terminal/console window. Older versions produce errors, but newer versions are fine.
101+
> Verify that you are running node 12.4.0 and npm 6.x.x by running node -v and npm -v in a terminal/console window. Older versions produce errors, but newer versions are fine.
102102
103103
```bash
104104
npm i

src/i18n/messages.es.xlf

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</source><target state="final">
99
Inicio
1010
</target>
11-
11+
1212
<context-group purpose="location"><context context-type="sourcefile">app/shared/components/header/header.component.html</context><context context-type="linenumber">5</context></context-group></trans-unit><trans-unit id="findHero" datatype="html">
1313
<source>Look for a hero!</source><target state="final">Busca un heroe!</target>
1414
<context-group purpose="location">
@@ -84,50 +84,50 @@
8484
<source>
8585
Heroes list
8686
</source><target state="translated">Lista de heroes</target>
87-
87+
8888
<context-group purpose="location"><context context-type="sourcefile">app/shared/components/header/header.component.html</context><context context-type="linenumber">8</context></context-group><context-group purpose="location"><context context-type="sourcefile">app/modules/heroes/pages/heroes-list-page/heroes-list-page.component.html</context><context context-type="linenumber">2</context></context-group></trans-unit>
8989
<trans-unit id="createHero" datatype="html">
9090
<source>Create a hero</source><target state="final">Crear un heroe</target>
91-
91+
9292
<context-group purpose="location"><context context-type="sourcefile">app/modules/heroes/pages/heroes-list-page/heroes-list-page.component.html</context><context context-type="linenumber">46</context></context-group></trans-unit>
9393
<trans-unit id="create" datatype="html">
9494
<source>Create</source><target state="final">Crear</target>
95-
96-
95+
96+
9797
<context-group purpose="location"><context context-type="sourcefile">app/modules/heroes/pages/heroes-list-page/heroes-list-page.component.html</context><context context-type="linenumber">56</context></context-group><context-group purpose="location"><context context-type="sourcefile">app/modules/heroes/pages/heroes-list-page/heroes-list-page.component.html</context><context context-type="linenumber">89</context></context-group></trans-unit>
9898
<trans-unit id="nameWithPalindrome" datatype="html">
9999
<source>Name (Palindrome?)</source><target state="final">Nombre (Palindrome?)</target>
100-
100+
101101
<context-group purpose="location"><context context-type="sourcefile">app/modules/heroes/pages/heroes-list-page/heroes-list-page.component.html</context><context context-type="linenumber">64</context></context-group></trans-unit>
102102
<trans-unit id="nameRequired" datatype="html">
103103
<source>
104104
Name is required
105105
</source><target state="final">
106106
El nombre es requerido
107107
</target>
108-
109-
108+
109+
110110
<context-group purpose="location"><context context-type="sourcefile">app/modules/heroes/pages/heroes-list-page/heroes-list-page.component.html</context><context context-type="linenumber">67</context></context-group><context-group purpose="location"><context context-type="sourcefile">app/modules/heroes/pages/heroes-list-page/heroes-list-page.component.html</context><context context-type="linenumber">80</context></context-group></trans-unit>
111111
<trans-unit id="maxLengthError" datatype="html">
112112
<source>
113113
The field is too long
114114
</source><target state="translated">
115115
El texto es demasiado largo
116116
</target>
117-
118-
117+
118+
119119
<context-group purpose="location"><context context-type="sourcefile">app/modules/heroes/pages/heroes-list-page/heroes-list-page.component.html</context><context context-type="linenumber">70</context></context-group><context-group purpose="location"><context context-type="sourcefile">app/modules/heroes/pages/heroes-list-page/heroes-list-page.component.html</context><context context-type="linenumber">83</context></context-group></trans-unit>
120120
<trans-unit id="realName" datatype="html">
121121
<source>Real name</source><target state="final">Nombre real</target>
122-
122+
123123
<context-group purpose="location"><context context-type="sourcefile">app/modules/heroes/pages/heroes-list-page/heroes-list-page.component.html</context><context context-type="linenumber">77</context></context-group></trans-unit>
124124
<trans-unit id="errorHasOcurred" datatype="html">
125125
<source>An error has ocurred</source><target state="final">Ha ocurrido un error</target>
126-
126+
127127
<context-group purpose="location"><context context-type="sourcefile">app/modules/heroes/pages/heroes-list-page/heroes-list-page.component.html</context><context context-type="linenumber">92</context></context-group></trans-unit>
128128
<trans-unit id="firstTwoHeroesById" datatype="html">
129129
<source>Heroes (1-2)</source><target state="final">Heroes (1-2)</target>
130-
130+
131131
<context-group purpose="location"><context context-type="sourcefile">app/modules/heroes/pages/heroes-list-page/heroes-list-page.component.html</context><context context-type="linenumber">97</context></context-group></trans-unit>
132132
<trans-unit id="heroDetail" datatype="html">
133133
<source>Hero detail</source><target state="final">Detalle del heroe</target>
@@ -136,7 +136,7 @@
136136
<context context-type="linenumber">1</context>
137137
</context-group>
138138
</trans-unit>
139-
139+
140140
<trans-unit id="goBack" datatype="html">
141141
<source>
142142
Go back
@@ -154,7 +154,7 @@ Volver
154154
</source><target state="final">
155155
Ancla al heroe
156156
</target>
157-
157+
158158
<context-group purpose="location"><context context-type="sourcefile">app/modules/heroes/pages/hero-detail-page/hero-detail-page.component.html</context><context context-type="linenumber">13</context></context-group></trans-unit><trans-unit id="@@appTitle" datatype="html">
159159
<source>App title</source><target state="final">App de ejemplo de Angular</target>
160160
<context-group purpose="location">
@@ -168,7 +168,7 @@ Ancla al heroe
168168
<context context-type="linenumber">1</context>
169169
</context-group>
170170
</trans-unit><trans-unit id="@@heroesMetaDescription" datatype="html">
171-
<source>Heroes meta description</source><target state="final">Lista de heroes - App de ejemplo en angular 7</target>
171+
<source>Heroes meta description</source><target state="final">Lista de heroes - App de ejemplo en angular 8</target>
172172
<context-group purpose="location">
173173
<context context-type="sourcefile">src/app/app.component.ts</context>
174174
<context context-type="linenumber">1</context>
@@ -187,7 +187,7 @@ Ancla al heroe
187187
</context-group>
188188
</trans-unit><trans-unit id="@@heroCreated" datatype="html">
189189
<source>Hero created</source><target state="final">Heroe creado</target>
190-
190+
191191
<context-group purpose="location"><context context-type="sourcefile">src/app/modules/heroes/pages/heroes-list-page/heroes-list-page.component.ts</context><context context-type="linenumber">1</context></context-group></trans-unit><trans-unit id="@@saved" datatype="html">
192192
<source>Saved</source><target state="final">Guardado</target>
193193
<context-group purpose="location">
@@ -196,7 +196,7 @@ Ancla al heroe
196196
</context-group>
197197
</trans-unit><trans-unit id="@@cannotVote" datatype="html">
198198
<source>Can't vote anymore</source><target state="final">No puedes votar más</target>
199-
199+
200200
<context-group purpose="location"><context context-type="sourcefile">src/app/modules/heroes/pages/heroes-list-page/heroes-list-page.component.ts</context><context context-type="linenumber">1</context></context-group><context-group purpose="location"><context context-type="sourcefile">src/app/shared/components/hero-card/hero-card.component.ts</context><context context-type="linenumber">1</context></context-group></trans-unit><trans-unit id="@@heroRemoved" datatype="html">
201201
<source>Hero removed</source><target state="final">Heroe eliminado</target>
202202
<context-group purpose="location">

0 commit comments

Comments
 (0)