Skip to content

Commit 544142d

Browse files
Ismaestroiramos
authored andcommitted
feat(lazy loading images): add ngx-progressive-image-loader
1 parent b913519 commit 544142d

File tree

16 files changed

+96
-72
lines changed

16 files changed

+96
-72
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
* Following the [best practices](https://angular.io/guide/styleguide)!
6666
* Search bar, to look for heroes
6767
* Custom loading page
68+
* Lazy loading images with [ngx-progressive-image-loader](https://github.com/maxisam/ngx-progressive-image-loader)
6869
* Modal and toasts (snakbar)!
6970
* Scroll restoration and anchor examples
7071
* Responsive layout (flex layout module)

angular.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
],
4848
"styles": [
4949
"node_modules/@angular/material/prebuilt-themes/deeppurple-amber.css",
50+
"node_modules/ngx-progressive-image-loader/ngx-progressive-image-loader.scss",
5051
"src/assets/css/reset.css",
5152
"src/assets/css/loading.css",
5253
"src/app/styles/global.scss"
@@ -292,7 +293,8 @@
292293
"builder": "@angular-devkit/build-angular:protractor",
293294
"options": {
294295
"protractorConfig": "e2e/protractor.conf.js",
295-
"devServerTarget": "angularexampleapp:serve"
296+
"devServerTarget": "angularexampleapp:serve",
297+
"port": 4201
296298
}
297299
},
298300
"lint": {

functions/package-lock.json

Lines changed: 49 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

functions/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,10 @@
3838
"express": "4.16.4",
3939
"firebase": "5.8.5",
4040
"firebase-admin": "7.0.0",
41-
"firebase-functions": "2.2.0",
41+
"firebase-functions": "2.2.1",
4242
"moment": "2.24.0",
43+
"ngx-progressive-image-loader": "4.0.0-beta.7",
44+
"ngx-window-token": "2.0.1",
4345
"reflect-metadata": "0.1.13",
4446
"rxjs": "6.4.0",
4547
"tslib": "1.9.3",

package-lock.json

Lines changed: 7 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"start": "ng serve --configuration=en --open",
77
"start:es": "ng serve --configuration=es --open",
88
"extract-i18n": "ng xi18n angularexampleapp --i18n-format xlf --output-path i18n --i18n-locale en && ngx-extractor --input=\"src/**/*.ts\" --format=xlf --out-file=src/i18n/messages.xlf && ng run angularexampleapp:xliffmerge",
9-
"lint": "tslint ./src/**/*.ts -t verbose",
9+
"lint": "tslint --project tslint.json ./src/**/*.ts -t verbose",
1010
"test": "ng test --code-coverage --no-watch --source-map=false",
1111
"test:app:watch": "ng test angularexampleapp --code-coverage --watch=true",
1212
"test:library:watch": "ng test ngx-example-library --code-coverage --watch=true",
@@ -56,6 +56,8 @@
5656
"express": "4.16.4",
5757
"firebase": "5.8.4",
5858
"ng-animate": "0.3.4",
59+
"ngx-progressive-image-loader": "4.0.0-beta.7",
60+
"ngx-window-token": "2.0.1",
5961
"rxjs": "6.4.0",
6062
"web-animations-js": "2.3.1",
6163
"zone.js": "0.8.29"
@@ -93,7 +95,6 @@
9395
"karma-mocha-reporter": "2.2.5",
9496
"karma-parallel": "0.3.1",
9597
"karma-remap-istanbul": "0.6.0",
96-
"karma-scss-preprocessor": "4.0.0",
9798
"moment": "2.24.0",
9899
"ng-bullet": "1.0.3",
99100
"ng-mocks": "7.7.0",

server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,5 @@ routes.forEach((route) => {
4444
});
4545

4646
app.listen(PORT, () => {
47-
console.log(`Node server listening on port ${PORT}`);
47+
console.log(`Node server listening on http://localhost:${PORT}`);
4848
});

src/app/app.module.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import {I18n} from '@ngx-translate/i18n-polyfill';
1212
import {HttpClientModule} from '@angular/common/http';
1313
import {registerLocaleData} from '@angular/common';
1414
import localeEs from '@angular/common/locales/es';
15+
import {NgxProgressiveImageLoaderModule} from 'ngx-progressive-image-loader';
1516

1617
declare const require;
1718

@@ -27,6 +28,7 @@ registerLocaleData(localeEs, 'es');
2728
say: 'hello'
2829
}
2930
}),
31+
NgxProgressiveImageLoaderModule.forRoot(),
3032
CoreModule,
3133
SharedModule,
3234
AppRoutingModule

src/app/configs/app.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export const AppConfig: any = {
88
error404: '404'
99
},
1010
votesLimit: 3,
11-
topHeroesLimit: 4,
11+
topHeroesLimit: 5,
1212
snackBarDuration: 3000,
1313
repositoryURL: 'https://github.com/ismaestro/angular7-example-app',
1414
sentryDSN: 'https://[email protected]/1315526'

src/app/modules/heroes/shared/hero.model.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ export class Hero implements Deserializable {
77
likes: number;
88
default: boolean;
99
avatarUrl: string;
10+
avatarBlurredUrl: string;
1011
avatarThumbnailUrl: string;
1112

1213
constructor(hero: any = {}) {
@@ -16,6 +17,7 @@ export class Hero implements Deserializable {
1617
this.likes = hero.likes || 0;
1718
this.default = hero.default || false;
1819
this.avatarUrl = hero.avatarUrl || '';
20+
this.avatarBlurredUrl = hero.avatarBlurredUrl || '';
1921
this.avatarThumbnailUrl = hero.avatarThumbnailUrl || '';
2022
}
2123

0 commit comments

Comments
 (0)