[FIX] account_edi_ubl_cii: revert mandatory buyer ref sending rechnung

This commit reverts 5594b08 because while buyer reference is mandatory for B2G it is not for B2C and B2B:

"The buyer reference must be indicated on every electronic invoice to public contracting authorities of the federal administration."

https://en.e-rechnung-bund.de/e-invoicing-faq/buyer-reference/

opw-4460079

closes odoo#202790

X-original-commit: 280b731
Signed-off-by: Antoine Dupuis (andu) <[email protected]>
Signed-off-by: Guillaume Teboul-Tornezy (gute) <[email protected]>

Author: gteboul

addons/account_edi_ubl_cii/models/account_edi_xml_ubl_xrechnung.py

@@ -33,7 +33,6 @@ def _export_invoice_constraints(self, invoice, vals):
         constraints.update({
             'bis3_de_supplier_telephone_required': self._check_required_fields(vals['supplier'], ['phone', 'mobile']),
             'bis3_de_supplier_electronic_mail_required': self._check_required_fields(vals['supplier'], 'email'),
-            'bis3_de_buyer_reference_required': self._check_required_fields(vals['customer'], 'ref'),
         })
 
         return constraints

addons/l10n_account_edi_ubl_cii_tests/tests/test_xml_ubl_de.py

@@ -297,37 +297,3 @@ def test_import_export_invoice_xml(self):
         self._detach_attachment(attachment)
         created_bill.message_post(attachment_ids=[attachment.id])
         self.assertTrue(created_bill)
-
-    def test_ensure_buyer_reference_xrechnung_xml(self):
-        acc_bank = self.env['res.partner.bank'].create({
-            'acc_number': 'BE15001559627232',
-            'partner_id': self.company_data['company'].partner_id.id,
-        })
-
-        self.partner_1.ref = False
-        invoice = self._generate_move(
-            self.partner_1,
-            self.partner_2,
-            move_type='out_invoice',
-            partner_id=self.partner_1.id,
-            partner_bank_id=acc_bank.id,
-            invoice_date='2017-01-01',
-            date='2017-01-01',
-            invoice_line_ids=[{
-                'product_id': self.product_a.id,
-                'product_uom_id': self.env.ref('uom.product_uom_dozen').id,
-                'price_unit': 275.0,
-                'quantity': 5,
-                'discount': 20.0,
-                'tax_ids': [(6, 0, self.tax_19.ids)],
-            }],
-        )
-
-        with self.assertRaises(UserError):
-            self.env['account.move.send'].with_context(
-                active_model='account.move',
-                active_ids=invoice.ids,
-            ).create({
-                'checkbox_download': False,
-                'checkbox_send_mail': False,
-            }).action_send_and_print()