strict typedef

Author: jdneo

src/commands/session.ts

@@ -7,7 +7,7 @@ import { executeCommand } from "../utils/cpUtils";
 import { DialogType, promptForOpenOutputChannel, promptForSignIn } from "../utils/uiUtils";
 
 export async function getSessionList(channel: vscode.OutputChannel): Promise<ISession[]> {
-    const signInStatus = leetCodeManager.getUser();
+    const signInStatus: string | undefined = leetCodeManager.getUser();
     if (!signInStatus) {
         promptForSignIn();
         return [];
@@ -75,7 +75,7 @@ async function parseSessionsToPicks(channel: vscode.OutputChannel): Promise<Arra
 export async function createSession(channel: vscode.OutputChannel): Promise<void> {
     const session: string | undefined = await vscode.window.showInputBox({
         prompt: "Enter the new session name.",
-        validateInput: (s: string) => s && s.trim() ? undefined : "Session name must not be empty",
+        validateInput: (s: string): string | undefined => s && s.trim() ? undefined : "Session name must not be empty",
     });
     if (!session) {
         return;

src/commands/show.ts

@@ -39,7 +39,7 @@ export async function searchProblem(channel: vscode.OutputChannel): Promise<void
 async function showProblemInternal(channel: vscode.OutputChannel, id: string): Promise<void> {
     try {
         const leetCodeConfig: vscode.WorkspaceConfiguration = vscode.workspace.getConfiguration("leetcode");
-        let defaultLanguage = leetCodeConfig.get<string>("defaultLanguage");
+        let defaultLanguage: string | undefined = leetCodeConfig.get<string>("defaultLanguage");
         if (defaultLanguage && languages.indexOf(defaultLanguage) < 0) {
             defaultLanguage = undefined;
         }
@@ -54,7 +54,7 @@ async function showProblemInternal(channel: vscode.OutputChannel, id: string): P
         const reg: RegExp = /\* Source Code:\s*(.*)/;
         const match: RegExpMatchArray | null = result.match(reg);
         if (match && match.length >= 2) {
-            const filePath = wsl.useWsl() ? wsl.toWinPath(match[1].trim()) : match[1].trim();
+            const filePath: string = wsl.useWsl() ? wsl.toWinPath(match[1].trim()) : match[1].trim();
 
             await vscode.window.showTextDocument(vscode.Uri.file(filePath), { preview: false });
         } else {

src/commands/test.ts

@@ -52,7 +52,7 @@ export async function testSolution(channel: vscode.OutputChannel, uri?: vscode.U
             case ":direct":
                 const testString: string | undefined = await vscode.window.showInputBox({
                     prompt: "Enter the test cases.",
-                    validateInput: (s: string) => s && s.trim() ? undefined : "Test case must not be empty.",
+                    validateInput: (s: string): string | undefined => s && s.trim() ? undefined : "Test case must not be empty.",
                     placeHolder: "Example: [1,2,3]\\n4",
                     ignoreFocusOut: true,
                 });

src/extension.ts

@@ -10,7 +10,7 @@ import { leetCodeManager } from "./leetCodeManager";
 import { leetCodeStatusBarItem } from "./leetCodeStatusBarItem";
 import { isNodeInstalled } from "./utils/nodeUtils";
 
-export async function activate(context: vscode.ExtensionContext) {
+export async function activate(context: vscode.ExtensionContext): Promise<void> {
     const channel: vscode.OutputChannel = vscode.window.createOutputChannel("LeetCode");
     if (!await isNodeInstalled(channel)) {
         return;
@@ -37,6 +37,6 @@ export async function activate(context: vscode.ExtensionContext) {
     });
 }
 
-export function deactivate() {
+export function deactivate(): void {
     leetCodeStatusBarItem.dispose();
 }

src/leetCodeExplorer.ts

@@ -8,7 +8,7 @@ import { ProblemState } from "./shared";
 
 // tslint:disable:max-classes-per-file
 export class LeetCodeNode {
-    constructor(private data: list.IProblem, private isProblemNode = true) { }
+    constructor(private data: list.IProblem, private isProblemNode: boolean = true) { }
 
     public get locked(): boolean {
         return this.data.locked;

src/leetCodeManager.ts

@@ -29,7 +29,7 @@ class LeetCodeManager extends EventEmitter implements ILeetCodeManager {
 
     public async getLoginStatus(channel: vscode.OutputChannel): Promise<void> {
         try {
-            const result = await executeCommand(channel, "node", [leetCodeBinaryPath, "user"]);
+            const result: string = await executeCommand(channel, "node", [leetCodeBinaryPath, "user"]);
             this.currentUser = result.slice("You are now login as".length).trim();
             this.userStatus = UserStatus.SignedIn;
         } catch (error) {
@@ -60,7 +60,7 @@ class LeetCodeManager extends EventEmitter implements ILeetCodeManager {
                 childProc.on("error", reject);
                 const name: string | undefined = await vscode.window.showInputBox({
                     prompt: "Enter user name.",
-                    validateInput: (s: string) => s && s.trim() ? undefined : "User name must not be empty",
+                    validateInput: (s: string): string | undefined => s && s.trim() ? undefined : "User name must not be empty",
                 });
                 if (!name) {
                     childProc.kill();
@@ -70,7 +70,7 @@ class LeetCodeManager extends EventEmitter implements ILeetCodeManager {
                 const pwd: string | undefined = await vscode.window.showInputBox({
                     prompt: "Enter password.",
                     password: true,
-                    validateInput: (s: string) => s ? undefined : "Password must not be empty",
+                    validateInput: (s: string): string | undefined => s ? undefined : "Password must not be empty",
                 });
                 if (!pwd) {
                     childProc.kill();

src/shared.ts

@@ -4,7 +4,7 @@ import * as path from "path";
 import * as vscode from "vscode";
 import * as wsl from "./utils/wslUtils";
 
-let binPath = path.join(__dirname, "..", "..", "node_modules", "leetcode-cli", "bin", "leetcode");
+let binPath: string = path.join(__dirname, "..", "..", "node_modules", "leetcode-cli", "bin", "leetcode");
 
 if (wsl.useWsl()) {
     binPath = wsl.toWslPath(binPath);
@@ -21,7 +21,7 @@ export enum UserStatus {
     SignedOut = 2,
 }
 
-export const languages = [
+export const languages: string[] = [
     "bash",
     "c",
     "cpp",

src/utils/nodeUtils.ts

@@ -10,7 +10,7 @@ export async function isNodeInstalled(channel: vscode.OutputChannel): Promise<bo
         await executeCommand(channel, "node", ["-v"]);
         return true;
     } catch (error) {
-        const choice = await vscode.window.showErrorMessage(
+        const choice: vscode.MessageItem | undefined = await vscode.window.showErrorMessage(
             "LeetCode extension need Node.js installed in environment path",
             DialogOptions.open,
         );

src/utils/uiUtils.ts

@@ -36,7 +36,7 @@ export async function promptForOpenOutputChannel(message: string, type: DialogTy
 }
 
 export async function promptForSignIn(): Promise<void> {
-    const choice = await vscode.window.showInformationMessage(
+    const choice: vscode.MessageItem | undefined = await vscode.window.showInformationMessage(
         "Please sign in to LeetCode.",
         DialogOptions.yes,
         DialogOptions.no,

src/utils/workspaceUtils.ts

@@ -17,7 +17,7 @@ export async function selectWorkspaceFolder(): Promise<string> {
         }
     }
 
-    const workFolder = folder ? folder.uri.fsPath : path.join(os.homedir(), ".leetcode");
+    const workFolder: string = folder ? folder.uri.fsPath : path.join(os.homedir(), ".leetcode");
 
     return wsl.useWsl() ? wsl.toWslPath(workFolder) : workFolder;
 }

tslint.json

@@ -6,10 +6,26 @@
     "jsRules": {},
     "rules": {
         "object-literal-sort-keys": false,
-        "indent": [true, "spaces"],
+        "indent": [
+            true,
+            "spaces"
+        ],
         "no-string-literal": false,
         "no-namespace": false,
-        "max-line-length": [false, 120]
+        "max-line-length": [
+            false,
+            120
+        ],
+        "typedef": [
+            true,
+            "call-signature",
+            "arrow-call-signature",
+            "parameter",
+            "arrow-parameter",
+            "property-declaration",
+            "variable-declaration",
+            "member-variable-declaration"
+        ]
     },
     "rulesDirectory": []
-}
+}