Skip to content

Update the extension icon to align with the new VS Code design #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdneo opened this issue Aug 27, 2019 · 10 comments
Closed

Update the extension icon to align with the new VS Code design #401

jdneo opened this issue Aug 27, 2019 · 10 comments
Labels
help wanted Extra attention is needed

Comments

@jdneo
Copy link
Member

jdneo commented Aug 27, 2019

The icon we are using now is not align with the VS Code new design.
icon

@jdneo jdneo added the help wanted Extra attention is needed label Aug 27, 2019
@poppinlp
Copy link
Contributor

I've asked my friend for the logo.
Actually, he has asked me if there are some UI/UX design which we need, after he gave me that sidebar icon.

@jdneo
Copy link
Member Author

jdneo commented Aug 27, 2019

That would be great if he is willing to help. So far the extension icon and the sidebar icon is enough I think.

Does he has a GitHub account? We should thank to his contribution in our document.

@poppinlp
Copy link
Contributor

image
@jdneo We get 2 versions of the icon. The first one is closer to the new vscode icon. The second one is closer to the leetcode icon. Which one do you prefer?

@jdneo
Copy link
Member Author

jdneo commented Sep 10, 2019

Thanks @poppinlp. I prefer the first one, what do you think?

@poppinlp
Copy link
Contributor

Yep. Me too.
Okey. I'll send PR then. And adding him in the Acknowledgement part for his contribution.

@jdneo
Copy link
Member Author

jdneo commented Sep 10, 2019

Can't wait for it!! 😄

@jdneo
Copy link
Member Author

jdneo commented Sep 12, 2019

Hey @poppinlp ,

Any updates for the new icon PR? I'm planning to make a new release recently and wish we can have the new icon in the new release. 😄

@poppinlp
Copy link
Contributor

Sry, I'll send a PR today.

@poppinlp
Copy link
Contributor

Sorry for the late update. I've send a PR for it.
The original svg image got something wrong, so I asked my friend to give me a new one this morning.

@jdneo
Copy link
Member Author

jdneo commented Sep 16, 2019

That's fine. Don't worry.

@jdneo jdneo closed this as completed Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants