Skip to content

when filename is empty it uses the folder name to create a file #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iFun opened this issue Sep 26, 2019 · 2 comments · Fixed by #433
Closed

when filename is empty it uses the folder name to create a file #432

iFun opened this issue Sep 26, 2019 · 2 comments · Fixed by #433
Labels
bug Something isn't working
Milestone

Comments

@iFun
Copy link
Contributor

iFun commented Sep 26, 2019

🐛 Bug Report

"leetcode.filePath": {
    "default": {
        // relative folder path
        "folder": "${tag}/${language}",
        // file name
        "filename": ""
    }
},

I leave the filename as blank because I wanted the old default filename and run into cannot create file error because it uses the folder name as the filename

To Reproduce

copy above and see the result

Expected behavior

folder name should be use as the filename

Extension Output

Paste here the LeetCode extension log from output channel.

Guidance: Press Ctrl+Shift+U, and toggle the channel to LeetCode.

Your Environment

  • os:
  • extension settings:
  • nodejs version:
  • vscode version:
  • extension version:
@jdneo
Copy link
Member

jdneo commented Sep 27, 2019

Expected behavior

folder name should be use as the filename

Is this sentence wrongly expressed?

@jdneo jdneo added the need more info Further information is requested label Sep 27, 2019
@iFun
Copy link
Contributor Author

iFun commented Sep 27, 2019

Expected behavior

folder name should be use as the filename

Is this sentence wrongly expressed?
Capture

yeah sorry, The expect behavior is that the folder name should not be use as filename. In the capture above the tag in the foldername is used as create filename which causes problem

It did not create a folder view like /linked-list/python3/add two number.py
instead it created a folder linked-list and named the file as python3

@no-response no-response bot removed the need more info Further information is requested label Sep 27, 2019
@jdneo jdneo added the bug Something isn't working label Sep 27, 2019
@jdneo jdneo added this to the 0.15.5 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants