Skip to content

using wsl feature not work #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LNKLEO opened this issue Feb 13, 2020 · 1 comment
Closed

using wsl feature not work #509

LNKLEO opened this issue Feb 13, 2020 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@LNKLEO
Copy link
Contributor

LNKLEO commented Feb 13, 2020

🐛 Bug Report

using wsl feature active failed
after fixe this above, it can't fetch problem list
file path conversion between windows and wsl failed during open new problem

To Reproduce

simply active use wsl setting and reopen the extension

Expected behavior

should work as normal

Extension Output

some import error and "wsl node" exit code 1
then output has show the problem list while sidebar shows none of them, also a error pops up

Your Environment

  • os: Windows 10 Insider Build 19559
  • extension settings: using wsl (not remote wsl, but build-in feature from extension)
  • nodejs version: 13.8 from wsl
  • vscode version: 1.43 insider
  • extension version: 0.16.0

i have pointed out the bug, and fixed locally.
you converted the path to wsl path too early since the binary path is illegal

@LNKLEO
Copy link
Contributor Author

LNKLEO commented Feb 13, 2020

a pr [#510] is already created
some reduntant variable and function related removed

@jdneo jdneo added the bug Something isn't working label Feb 20, 2020
@jdneo jdneo closed this as completed Feb 22, 2020
@jdneo jdneo added this to the 0.16.1 milestone Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants