Skip to content

Commit 6b03da6

Browse files
naushirkbingham
authored andcommitted
ipa: raspberrypi: Fix bug in IPA frame drop logic
Fix a bug in the IPA frame dropping (for rate control) logic, where the metadata for the current context was copied from itself (i.e. a no-op), instead of being copied from the previous context. This bug does not occur in normal conditions, only when running with a low exposure time and unconstrained framerate, which happens in a particular picamera2 test. Fixes: 546154b ("pipeline: ipa: raspberrypi: Use IPA cookies") Signed-off-by: Naushir Patuck <[email protected]> Reviewed-by: Kieran Bingham <[email protected]> Reviewed-by: David Plowman <[email protected]> Signed-off-by: Kieran Bingham <[email protected]>
1 parent ac42f92 commit 6b03da6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/ipa/raspberrypi/raspberrypi.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1062,7 +1062,7 @@ void IPARPi::prepareISP(const ISPConfig &data)
10621062
* in helper_->Prepare().
10631063
*/
10641064
RPiController::Metadata &lastMetadata =
1065-
rpiMetadata_[ipaContext ? ipaContext : rpiMetadata_.size()];
1065+
rpiMetadata_[(ipaContext ? ipaContext : rpiMetadata_.size()) - 1];
10661066
rpiMetadata.mergeCopy(lastMetadata);
10671067
processPending_ = false;
10681068
return;

0 commit comments

Comments
 (0)