Do not error for unknown files if send_file sends an actual file

Author: mitsuhiko

flask/helpers.py

@@ -513,7 +513,8 @@ def send_file(filename_or_fp, mimetype=None, as_attachment=False,
 
     if mimetype is None:
         if attachment_filename is not None:
-            mimetype = mimetypes.guess_type(attachment_filename)[0]
+            mimetype = mimetypes.guess_type(attachment_filename)[0] \
+                or 'application/octet-stream'
 
         if mimetype is None:
             if attachment_filename is not None:

tests/test_helpers.py

@@ -402,9 +402,7 @@ def test_send_file_object_without_mimetype(self):
             assert 'no filename is available' in str(excinfo)
 
         with app.test_request_context():
-            with pytest.raises(ValueError) as excinfo:
-                flask.send_file(StringIO("LOL"), attachment_filename='filename')
-            assert "Unable to infer MIME-type from filename 'filename'" in str(excinfo)
+            flask.send_file(StringIO("LOL"), attachment_filename='filename')
 
     def test_send_file_object(self):
         app = flask.Flask(__name__)