Skip to content

Commit 3683c5e

Browse files
committed
Eigen 3.3.9 released yesterday
1 parent 09e8a6d commit 3683c5e

File tree

86 files changed

+1243
-918
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

86 files changed

+1243
-918
lines changed

inst/include/Eigen/CholmodSupport

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#include "src/Core/util/DisableStupidWarnings.h"
1414

1515
extern "C" {
16-
#include <RcppEigenCholmod.h>
16+
#include <cholmod.h>
1717
}
1818

1919
/** \ingroup Support_modules
@@ -45,3 +45,4 @@ extern "C" {
4545
#include "src/Core/util/ReenableStupidWarnings.h"
4646

4747
#endif // EIGEN_CHOLMODSUPPORT_MODULE_H
48+

inst/include/Eigen/Core

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,10 @@
279279
#include <cmath>
280280
#include <cassert>
281281
#include <functional>
282-
#include <iosfwd>
282+
#include <sstream>
283+
#ifndef EIGEN_NO_IO
284+
#include <iosfwd>
285+
#endif
283286
#include <cstring>
284287
#include <string>
285288
#include <limits>
@@ -375,7 +378,9 @@ using std::ptrdiff_t;
375378

376379
#if defined EIGEN_VECTORIZE_AVX512
377380
#include "src/Core/arch/SSE/PacketMath.h"
381+
#include "src/Core/arch/SSE/MathFunctions.h"
378382
#include "src/Core/arch/AVX/PacketMath.h"
383+
#include "src/Core/arch/AVX/MathFunctions.h"
379384
#include "src/Core/arch/AVX512/PacketMath.h"
380385
#include "src/Core/arch/AVX512/MathFunctions.h"
381386
#elif defined EIGEN_VECTORIZE_AVX

inst/include/Eigen/Eigenvalues

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@
1010

1111
#include "Core"
1212

13-
#include "src/Core/util/DisableStupidWarnings.h"
14-
1513
#include "Cholesky"
1614
#include "Jacobi"
1715
#include "Householder"
1816
#include "LU"
1917
#include "Geometry"
2018

19+
#include "src/Core/util/DisableStupidWarnings.h"
20+
2121
/** \defgroup Eigenvalues_Module Eigenvalues module
2222
*
2323
*

inst/include/Eigen/Geometry

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010

1111
#include "Core"
1212

13-
#include "src/Core/util/DisableStupidWarnings.h"
14-
1513
#include "SVD"
1614
#include "LU"
1715
#include <limits>
1816

17+
#include "src/Core/util/DisableStupidWarnings.h"
18+
1919
/** \defgroup Geometry_Module Geometry module
2020
*
2121
* This module provides support for:

inst/include/Eigen/QR

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010

1111
#include "Core"
1212

13-
#include "src/Core/util/DisableStupidWarnings.h"
14-
1513
#include "Cholesky"
1614
#include "Jacobi"
1715
#include "Householder"
1816

17+
#include "src/Core/util/DisableStupidWarnings.h"
18+
1919
/** \defgroup QR_Module QR module
2020
*
2121
*

inst/include/Eigen/SparseQR

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
*
2929
*/
3030

31-
#include "OrderingMethods"
3231
#include "src/SparseCore/SparseColEtree.h"
3332
#include "src/SparseQR/SparseQR.h"
3433

inst/include/Eigen/src/Core/ArrayBase.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,8 @@ template<typename Derived> class ArrayBase
153153
// inline void evalTo(Dest& dst) const { dst = matrix(); }
154154

155155
protected:
156-
EIGEN_DEVICE_FUNC
157-
ArrayBase() : Base() {}
156+
EIGEN_DEFAULT_COPY_CONSTRUCTOR(ArrayBase)
157+
EIGEN_DEFAULT_EMPTY_CONSTRUCTOR_AND_DESTRUCTOR(ArrayBase)
158158

159159
private:
160160
explicit ArrayBase(Index);

inst/include/Eigen/src/Core/CwiseUnaryView.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ class CwiseUnaryViewImpl<ViewOp,MatrixType,Dense>
121121
{
122122
return derived().nestedExpression().outerStride() * sizeof(typename internal::traits<MatrixType>::Scalar) / sizeof(Scalar);
123123
}
124+
protected:
125+
EIGEN_DEFAULT_EMPTY_CONSTRUCTOR_AND_DESTRUCTOR(CwiseUnaryViewImpl)
124126
};
125127

126128
} // end namespace Eigen

inst/include/Eigen/src/Core/DenseBase.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ static inline void check_DenseIndex_is_signed() {
4040
*/
4141
template<typename Derived> class DenseBase
4242
#ifndef EIGEN_PARSED_BY_DOXYGEN
43-
: public DenseCoeffsBase<Derived>
43+
: public DenseCoeffsBase<Derived, internal::accessors_level<Derived>::value>
4444
#else
4545
: public DenseCoeffsBase<Derived,DirectWriteAccessors>
4646
#endif // not EIGEN_PARSED_BY_DOXYGEN
@@ -71,7 +71,7 @@ template<typename Derived> class DenseBase
7171
typedef Scalar value_type;
7272

7373
typedef typename NumTraits<Scalar>::Real RealScalar;
74-
typedef DenseCoeffsBase<Derived> Base;
74+
typedef DenseCoeffsBase<Derived, internal::accessors_level<Derived>::value> Base;
7575

7676
using Base::derived;
7777
using Base::const_cast_derived;
@@ -587,11 +587,12 @@ template<typename Derived> class DenseBase
587587
}
588588

589589
protected:
590+
EIGEN_DEFAULT_COPY_CONSTRUCTOR(DenseBase)
590591
/** Default constructor. Do nothing. */
591592
EIGEN_DEVICE_FUNC DenseBase()
592593
{
593594
/* Just checks for self-consistency of the flags.
594-
* Only do it when debugging Eigen, as this borders on paranoiac and could slow compilation down
595+
* Only do it when debugging Eigen, as this borders on paranoia and could slow compilation down
595596
*/
596597
#ifdef EIGEN_INTERNAL_DEBUGGING
597598
EIGEN_STATIC_ASSERT((EIGEN_IMPLIES(MaxRowsAtCompileTime==1 && MaxColsAtCompileTime!=1, int(IsRowMajor))

inst/include/Eigen/src/Core/DenseStorage.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ template<typename T, int _Options> class DenseStorage<T, Dynamic, Dynamic, Dynam
404404
if(size != m_rows*m_cols)
405405
{
406406
internal::conditional_aligned_delete_auto<T,(_Options&DontAlign)==0>(m_data, m_rows*m_cols);
407-
if (size)
407+
if (size>0) // >0 and not simply !=0 to let the compiler knows that size cannot be negative
408408
m_data = internal::conditional_aligned_new_auto<T,(_Options&DontAlign)==0>(size);
409409
else
410410
m_data = 0;
@@ -479,7 +479,7 @@ template<typename T, int _Rows, int _Options> class DenseStorage<T, Dynamic, _Ro
479479
if(size != _Rows*m_cols)
480480
{
481481
internal::conditional_aligned_delete_auto<T,(_Options&DontAlign)==0>(m_data, _Rows*m_cols);
482-
if (size)
482+
if (size>0) // >0 and not simply !=0 to let the compiler knows that size cannot be negative
483483
m_data = internal::conditional_aligned_new_auto<T,(_Options&DontAlign)==0>(size);
484484
else
485485
m_data = 0;
@@ -553,7 +553,7 @@ template<typename T, int _Cols, int _Options> class DenseStorage<T, Dynamic, Dyn
553553
if(size != m_rows*_Cols)
554554
{
555555
internal::conditional_aligned_delete_auto<T,(_Options&DontAlign)==0>(m_data, _Cols*m_rows);
556-
if (size)
556+
if (size>0) // >0 and not simply !=0 to let the compiler knows that size cannot be negative
557557
m_data = internal::conditional_aligned_new_auto<T,(_Options&DontAlign)==0>(size);
558558
else
559559
m_data = 0;

0 commit comments

Comments
 (0)