Fix automatic hstore extension creation not working on Django 4.2 or newer #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Photonios
force-pushed
the
fix-hstore-registration
branch
from
0cd410d to
377f0b9
Compare
…newer The following change broke the auto setup: django/django@d3e746a This breaks because the call to `pscygop2.extras.register_hstore` is now conditional. Before, it would be called multiple times with empty OIDS, when eventually our auto registration would kick in and psycopg2 would fetch the OIDs itself.
Photonios
force-pushed
the
fix-hstore-registration
branch
from
377f0b9 to
a810a7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following change broke the auto setup:
django/django@d3e746a
This breaks because the call to
pscygop2.extras.register_hstoreis nowconditional. Before, it would be called multiple times with
empty OIDS, when eventually our auto registration would kick
in and psycopg2 would fetch the OIDs itself.