[py] make custom exception for driver location

Author: titusfortner

py/selenium/common/__init__.py

@@ -34,12 +34,12 @@
 from .exceptions import NoAlertPresentException
 from .exceptions import NoSuchAttributeException
 from .exceptions import NoSuchCookieException
+from .exceptions import NoSuchDriverException
 from .exceptions import NoSuchElementException
 from .exceptions import NoSuchFrameException
 from .exceptions import NoSuchShadowRootException
 from .exceptions import NoSuchWindowException
 from .exceptions import ScreenshotException
-from .exceptions import SeleniumManagerException
 from .exceptions import SessionNotCreatedException
 from .exceptions import StaleElementReferenceException
 from .exceptions import TimeoutException
@@ -56,6 +56,7 @@
     "NoSuchWindowException",
     "NoSuchElementException",
     "NoSuchAttributeException",
+    "NoSuchDriverException",
     "NoSuchShadowRootException",
     "StaleElementReferenceException",
     "InvalidElementStateException",
@@ -82,5 +83,4 @@
     "InvalidSessionIdException",
     "SessionNotCreatedException",
     "UnknownMethodException",
-    "SeleniumManagerException",
 ]

py/selenium/common/exceptions.py

@@ -20,8 +20,9 @@
 from typing import Optional
 from typing import Sequence
 
-SUPPORT_MSG = 'For documentation on this error, please visit:'
-ERROR_URL = 'https://www.selenium.dev/documentation/webdriver/troubleshooting/errors'
+SUPPORT_MSG = "For documentation on this error, please visit:"
+ERROR_URL = "https://www.selenium.dev/documentation/webdriver/troubleshooting/errors"
+
 
 class WebDriverException(Exception):
     """Base webdriver exception."""
@@ -71,10 +72,11 @@ class NoSuchElementException(WebDriverException):
           (webpage is still loading) see selenium.webdriver.support.wait.WebDriverWait()
           for how to write a wait wrapper to wait for an element to appear.
     """
+
     def __init__(
         self, msg: Optional[str] = None, screen: Optional[str] = None, stacktrace: Optional[Sequence[str]] = None
     ) -> None:
-        with_support = f'{msg}; {SUPPORT_MSG} {ERROR_URL}#no-such-element-exception'
+        with_support = f"{msg}; {SUPPORT_MSG} {ERROR_URL}#no-such-element-exception"
 
         super().__init__(with_support, screen, stacktrace)
 
@@ -109,10 +111,11 @@ class StaleElementReferenceException(WebDriverException):
           node is rebuilt.
         * Element may have been inside an iframe or another context which was refreshed.
     """
+
     def __init__(
         self, msg: Optional[str] = None, screen: Optional[str] = None, stacktrace: Optional[Sequence[str]] = None
     ) -> None:
-        with_support = f'{msg}; {SUPPORT_MSG} {ERROR_URL}#stale-element-reference-exception'
+        with_support = f"{msg}; {SUPPORT_MSG} {ERROR_URL}#stale-element-reference-exception"
 
         super().__init__(with_support, screen, stacktrace)
 
@@ -207,10 +210,11 @@ class InvalidSelectorException(WebDriverException):
     expression) or the expression does not select WebElements (e.g.
     "count(//input)").
     """
+
     def __init__(
         self, msg: Optional[str] = None, screen: Optional[str] = None, stacktrace: Optional[Sequence[str]] = None
     ) -> None:
-        with_support = f'{msg}; {SUPPORT_MSG} {ERROR_URL}#invalid-selector-exception'
+        with_support = f"{msg}; {SUPPORT_MSG} {ERROR_URL}#invalid-selector-exception"
 
         super().__init__(with_support, screen, stacktrace)
 
@@ -273,5 +277,12 @@ class UnknownMethodException(WebDriverException):
     for that URL."""
 
 
-class SeleniumManagerException(WebDriverException):
-    """Raised when an issue interacting with selenium manager occurs."""
+class NoSuchDriverException(WebDriverException):
+    """Raised when driver is not specified and cannot be located."""
+
+    def __init__(
+        self, msg: Optional[str] = None, screen: Optional[str] = None, stacktrace: Optional[Sequence[str]] = None
+    ) -> None:
+        with_support = f"{msg}; {SUPPORT_MSG} {ERROR_URL}/driver_location"
+
+        super().__init__(with_support, screen, stacktrace)

py/selenium/webdriver/common/driver_finder.py

@@ -16,8 +16,9 @@
 # under the License.
 import logging
 import shutil
+from pathlib import Path
 
-from selenium.common.exceptions import WebDriverException
+from selenium.common.exceptions import NoSuchDriverException
 from selenium.webdriver.common.options import BaseOptions
 from selenium.webdriver.common.selenium_manager import SeleniumManager
 from selenium.webdriver.common.service import Service
@@ -36,10 +37,13 @@ def __init__(self) -> None:
 
     @staticmethod
     def get_path(service: Service, options: BaseOptions) -> str:
+        path = shutil.which(service.path)
         try:
-            path = shutil.which(service.path) or SeleniumManager().driver_location(options)
-        except WebDriverException as err:
-            logger.warning("Unable to obtain driver using Selenium Manager: " + err.msg)
-            raise err
+            path = SeleniumManager().driver_location(options) if path is None else path
+        except Exception as err:
+            raise NoSuchDriverException(f"Unable to obtain {service.path} using Selenium Manager; {err}")
+
+        if path is None or not Path(path).is_file():
+            raise NoSuchDriverException(f"Unable to locate or obtain {service.path}")
 
         return path

py/selenium/webdriver/common/selenium_manager.py

@@ -21,7 +21,7 @@
 from pathlib import Path
 from typing import List
 
-from selenium.common.exceptions import SeleniumManagerException
+from selenium.common import WebDriverException
 from selenium.webdriver.common.options import BaseOptions
 
 logger = logging.getLogger(__name__)
@@ -57,8 +57,7 @@ def get_binary() -> Path:
         path = Path(__file__).parent.joinpath(directory, file)
 
         if not path.is_file():
-            tracker = "https://github.com/SeleniumHQ/selenium/issues"
-            raise SeleniumManagerException(f"{path} is missing.  Please open an issue on {tracker}")
+            raise WebDriverException(f"Unable to obtain working Selenium Manager binary; {path}")
 
         return path
 
@@ -109,15 +108,18 @@ def run(args: List[str]) -> str:
         """
         command = " ".join(args)
         logger.debug(f"Executing process: {command}")
-        completed_proc = subprocess.run(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-        stdout = completed_proc.stdout.decode("utf-8").rstrip("\n")
-        stderr = completed_proc.stderr.decode("utf-8").rstrip("\n")
-        output = json.loads(stdout)
-        result = output["result"]["message"]
+        try:
+            completed_proc = subprocess.run(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+            stdout = completed_proc.stdout.decode("utf-8").rstrip("\n")
+            stderr = completed_proc.stderr.decode("utf-8").rstrip("\n")
+            output = json.loads(stdout)
+            result = output["result"]["message"]
+        except Exception as err:
+            raise WebDriverException(f"Unsuccessful command executed: {command}; {err}")
+
         if completed_proc.returncode:
-            raise SeleniumManagerException(f"Selenium Manager failed for: {command}.\n{result}{stderr}")
+            raise WebDriverException(f"Unsuccessful command executed: {command}.\n{result}{stderr}")
         else:
-            # Selenium Manager exited successfully, return executable path and print warnings
             for item in output["logs"]:
                 if item["level"] == "WARN":
                     logger.warning(item["message"])

py/test/selenium/webdriver/common/driver_element_finding_tests.py

@@ -99,6 +99,7 @@ def test_no_such_element_error(driver, pages):
     with pytest.raises(NoSuchElementException, match=msg):
         driver.find_element(By.ID, "non_Existent_Button")
 
+
 # By.name positive
 
 

py/test/selenium/webdriver/common/selenium_manager_tests.py

@@ -19,8 +19,10 @@
 
 import pytest
 
-from selenium.common.exceptions import SeleniumManagerException
+from selenium.common.exceptions import WebDriverException
 from selenium.webdriver.chrome.options import Options
+from selenium.webdriver.chrome.service import Service
+from selenium.webdriver.common.driver_finder import DriverFinder
 from selenium.webdriver.common.proxy import Proxy
 from selenium.webdriver.common.selenium_manager import SeleniumManager
 
@@ -85,8 +87,18 @@ def test_proxy_is_used_for_sm(mocker):
 
 
 def test_stderr_is_propagated_to_exception_messages():
-    msg = r"Selenium Manager failed for:.* --browser foo --output json\.\nInvalid browser name: foo\n"
-    with pytest.raises(SeleniumManagerException, match=msg):
+    msg = r"Unsuccessful command executed:.* --browser foo --output json\.\nInvalid browser name: foo\n"
+    with pytest.raises(WebDriverException, match=msg):
         manager = SeleniumManager()
         binary = manager.get_binary()
         _ = manager.run([str(binary), "--browser", "foo", "--output", "json"])
+
+
+def test_driver_finder_error(mocker):
+    mocker.patch("selenium.webdriver.common.selenium_manager.SeleniumManager.driver_location", return_value=None)
+
+    service = Service()
+    options = Options()
+    msg = r"Unable to locate or obtain chromedriver.*errors\/driver_location"
+    with pytest.raises(WebDriverException, match=msg):
+        DriverFinder.get_path(service, options)

py/test/selenium/webdriver/support/relative_by_tests.py

@@ -86,7 +86,7 @@ def test_no_such_element_is_raised_rather_than_index_error(driver, pages):
     with pytest.raises(NoSuchElementException) as exc:
         anchor = driver.find_element(By.ID, "second")
         driver.find_element(locate_with(By.ID, "nonexistentid").above(anchor))
-    assert exc.value.msg == "Cannot locate relative element with: {'id': 'nonexistentid'}"
+    assert "Cannot locate relative element with: {'id': 'nonexistentid'}" in exc.value.msg
 
 
 def test_near_locator_should_find_near_elements(driver, pages):
@@ -105,4 +105,4 @@ def test_near_locator_should_not_find_far_elements(driver, pages):
     with pytest.raises(NoSuchElementException) as exc:
         driver.find_element(locate_with(By.ID, "rect4").near(rect3))
 
-    assert exc.value.msg == "Cannot locate relative element with: {'id': 'rect4'}"
+    assert "Cannot locate relative element with: {'id': 'rect4'}" in exc.value.msg