Skip to content

Commit 6c13297

Browse files
author
L'In20Cible
committed
May as well move back the NameError from my testings...
1 parent 490cb07 commit 6c13297

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

src/core/modules/messages/messages.h

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@
9090
if (field_descriptor && strcmp(field_descriptor->name().c_str(), field_name) == 0)
9191
return field_descriptor;
9292
}
93+
94+
BOOST_RAISE_EXCEPTION(PyExc_NameError, "Unable to find field '%s'.", field_name);
9395
return NULL;
9496
}
9597

@@ -111,13 +113,7 @@
111113
google::protobuf::Message* pMessage,
112114
T (google::protobuf::Reflection::*get_field_delegate)(const google::protobuf::Message& message, const google::protobuf::FieldDescriptor* field) const,
113115
const char* field_name)
114-
{
115-
const google::protobuf::FieldDescriptor* field_descriptor = GetFieldDescriptor(pMessage, field_name);
116-
if (!field_descriptor)
117-
BOOST_RAISE_EXCEPTION(PyExc_NameError, "Unable to find field '%s'.", field_name);
118-
119-
return (*pMessage->GetReflection().*get_field_delegate)(*pMessage, field_descriptor);
120-
}
116+
{ return (*pMessage->GetReflection().*get_field_delegate)(*pMessage, GetFieldDescriptor(pMessage, field_name)); }
121117

122118
static int32 GetInt32(google::protobuf::Message* pMessage, const char* field_name)
123119
{ return GetField<int32>(pMessage, &google::protobuf::Reflection::GetInt32, field_name); }

0 commit comments

Comments
 (0)