From a3f1fcb45d8b669a73d87a049259986f62d8994a Mon Sep 17 00:00:00 2001 From: Taranjeet Singh Kalsi Date: Tue, 25 Oct 2022 15:30:16 +0530 Subject: [PATCH 1/2] removed extra loop in Anagram.java removed the extra loop in Anagram.java by using the equals function and added comment --- src/main/java/com/thealgorithms/strings/Anagrams.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/thealgorithms/strings/Anagrams.java b/src/main/java/com/thealgorithms/strings/Anagrams.java index 6ac104426271..40dabd00bd40 100644 --- a/src/main/java/com/thealgorithms/strings/Anagrams.java +++ b/src/main/java/com/thealgorithms/strings/Anagrams.java @@ -121,13 +121,12 @@ boolean approach4(String s, String t) { for (char c : t.toCharArray()) { kk.put(c, kk.getOrDefault(c, 0) + 1); } - // It checks for equal frequencies - for (char c : nm.keySet()) { - if (!nm.get(c).equals(kk.get(c))) { - return false; - } + // It checks for equal frequencies by comparing key-value pairs of two hashmaps + if (nm.equals(kk)) { + return true; + } else { + return false; } - return true; } } } From 67da6b01f7e3e608ab93b34e575a3833c015f97f Mon Sep 17 00:00:00 2001 From: Taranjeet Singh Kalsi Date: Tue, 25 Oct 2022 17:42:53 +0530 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Yang Libin --- src/main/java/com/thealgorithms/strings/Anagrams.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/main/java/com/thealgorithms/strings/Anagrams.java b/src/main/java/com/thealgorithms/strings/Anagrams.java index 40dabd00bd40..1d61e42e5852 100644 --- a/src/main/java/com/thealgorithms/strings/Anagrams.java +++ b/src/main/java/com/thealgorithms/strings/Anagrams.java @@ -122,11 +122,7 @@ boolean approach4(String s, String t) { kk.put(c, kk.getOrDefault(c, 0) + 1); } // It checks for equal frequencies by comparing key-value pairs of two hashmaps - if (nm.equals(kk)) { - return true; - } else { - return false; - } + return nm.equals(kk); } } }