From 7be303feafbb5d85b3c986667a63024d5cee424d Mon Sep 17 00:00:00 2001 From: Bekzod Date: Wed, 10 May 2023 14:17:45 +0500 Subject: [PATCH 1/4] fix error in SinglyLinkedList head method --- Data-Structures/Linked-List/SinglyLinkedList.js | 2 +- Data-Structures/Linked-List/test/SinglyLinkedList.test.js | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Data-Structures/Linked-List/SinglyLinkedList.js b/Data-Structures/Linked-List/SinglyLinkedList.js index ec0e31f5fc..e0f14a39a5 100644 --- a/Data-Structures/Linked-List/SinglyLinkedList.js +++ b/Data-Structures/Linked-List/SinglyLinkedList.js @@ -40,7 +40,7 @@ class LinkedList { // Returns the head head () { - return this.headNode?.data || null + return this.headNode?.data ?? null } // Returns the tail diff --git a/Data-Structures/Linked-List/test/SinglyLinkedList.test.js b/Data-Structures/Linked-List/test/SinglyLinkedList.test.js index 5435553437..e446fa53fa 100644 --- a/Data-Structures/Linked-List/test/SinglyLinkedList.test.js +++ b/Data-Structures/Linked-List/test/SinglyLinkedList.test.js @@ -148,6 +148,9 @@ describe('SinglyLinkedList', () => { list.addFirst(30) expect(list.head()).toBe(30) + + list.addFirst(0) + expect(list.head()).toBe(0) }) it('Check tail', () => { From 8e33642f9918cfd83db542b27f22e4d887509183 Mon Sep 17 00:00:00 2001 From: Bekzod Date: Wed, 10 May 2023 16:08:59 +0500 Subject: [PATCH 2/4] test: update check head test for SinglyLinkedList --- Data-Structures/Linked-List/test/SinglyLinkedList.test.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Data-Structures/Linked-List/test/SinglyLinkedList.test.js b/Data-Structures/Linked-List/test/SinglyLinkedList.test.js index e446fa53fa..5ac2d3b9b4 100644 --- a/Data-Structures/Linked-List/test/SinglyLinkedList.test.js +++ b/Data-Structures/Linked-List/test/SinglyLinkedList.test.js @@ -148,9 +148,10 @@ describe('SinglyLinkedList', () => { list.addFirst(30) expect(list.head()).toBe(30) - - list.addFirst(0) - expect(list.head()).toBe(0) + + // check for a falsy head data + list.addFirst(false) + expect(list.head()).toBe(false) }) it('Check tail', () => { From 194e302d85be3a0cf3b5c825763343bad710d2f1 Mon Sep 17 00:00:00 2001 From: Bekzod Date: Wed, 10 May 2023 16:16:11 +0500 Subject: [PATCH 3/4] fix: code style error --- Data-Structures/Linked-List/test/SinglyLinkedList.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Data-Structures/Linked-List/test/SinglyLinkedList.test.js b/Data-Structures/Linked-List/test/SinglyLinkedList.test.js index 5ac2d3b9b4..d0681f93a5 100644 --- a/Data-Structures/Linked-List/test/SinglyLinkedList.test.js +++ b/Data-Structures/Linked-List/test/SinglyLinkedList.test.js @@ -148,7 +148,7 @@ describe('SinglyLinkedList', () => { list.addFirst(30) expect(list.head()).toBe(30) - + // check for a falsy head data list.addFirst(false) expect(list.head()).toBe(false) From 9ba3fba329b89ab7e8b8298d209764e4f764fe49 Mon Sep 17 00:00:00 2001 From: Bekzod Date: Sun, 14 May 2023 16:47:44 +0500 Subject: [PATCH 4/4] fix: remove extra semicolons --- Data-Structures/Linked-List/SinglyLinkedList.js | 2 +- Data-Structures/Linked-List/test/SinglyLinkedList.test.js | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Data-Structures/Linked-List/SinglyLinkedList.js b/Data-Structures/Linked-List/SinglyLinkedList.js index e0f14a39a5..b093d4bde6 100644 --- a/Data-Structures/Linked-List/SinglyLinkedList.js +++ b/Data-Structures/Linked-List/SinglyLinkedList.js @@ -45,7 +45,7 @@ class LinkedList { // Returns the tail tail () { - return this.tailNode?.data || null + return this.tailNode?.data ?? null } // Return if the list is empty diff --git a/Data-Structures/Linked-List/test/SinglyLinkedList.test.js b/Data-Structures/Linked-List/test/SinglyLinkedList.test.js index d0681f93a5..53be70884d 100644 --- a/Data-Structures/Linked-List/test/SinglyLinkedList.test.js +++ b/Data-Structures/Linked-List/test/SinglyLinkedList.test.js @@ -166,6 +166,10 @@ describe('SinglyLinkedList', () => { list.addFirst(30) expect(list.tail()).toBe(20) + + // check for a falsy tail data + list.addLast(false) + expect(list.tail()).toBe(false) }) it('Check size', () => {