From 4474922f960525195fc1fbee6e71e3aaebfbc8b0 Mon Sep 17 00:00:00 2001 From: Piotr Idzik Date: Fri, 8 Mar 2024 21:46:42 +0000 Subject: [PATCH 1/2] tests: add missing test of `twinPrime` --- Maths/test/TwinPrime.test.js | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/Maths/test/TwinPrime.test.js b/Maths/test/TwinPrime.test.js index c3e057e10e..fedd2909b3 100644 --- a/Maths/test/TwinPrime.test.js +++ b/Maths/test/TwinPrime.test.js @@ -1,10 +1,13 @@ import { twinPrime } from '../TwinPrime.js' -describe('Twin Primes', () => { - it('Should be valid twin primes', () => { - expect(twinPrime(3)).toBe(5) - expect(twinPrime(5)).toBe(7) - expect(twinPrime(4)).toBe(-1) - expect(twinPrime(17)).toBe(19) +describe('twinPrime', () => { + it.each([ + [3, 5], + [5, 7], + [7, -1], + [4, -1], + [17, 19] + ])('for input %i returns %i', (n, expected) => { + expect(twinPrime(n)).toBe(expected) }) }) From 9456fd6cec31b6040d0692b17ac3328ab7794242 Mon Sep 17 00:00:00 2001 From: Piotr Idzik Date: Mon, 11 Mar 2024 03:41:08 +0000 Subject: [PATCH 2/2] feat: remove `twinPrime` --- Maths/TwinPrime.js | 29 ----------------------------- Maths/test/TwinPrime.test.js | 13 ------------- 2 files changed, 42 deletions(-) delete mode 100644 Maths/TwinPrime.js delete mode 100644 Maths/test/TwinPrime.test.js diff --git a/Maths/TwinPrime.js b/Maths/TwinPrime.js deleted file mode 100644 index 0bb17e0ebe..0000000000 --- a/Maths/TwinPrime.js +++ /dev/null @@ -1,29 +0,0 @@ -import { PrimeCheck } from './PrimeCheck' - -/** - * @function twinPrime - * Gets the 'twin prime' of a prime number. - * - * @param {Integer} n The number to find the twin prime of. - * @returns {Integer} Either the twin, or -1 if n or n + 2 is not prime. - * - * @see https://en.wikipedia.org/wiki/Twin_prime - * - * @example twinPrime(5) = 7 - * @example twinPrime(4) = -1 - */ -function twinPrime(n) { - const prime = PrimeCheck(n) - - if (!prime) { - return -1 - } - - if (!PrimeCheck(n + 2)) { - return -1 - } - - return n + 2 -} - -export { twinPrime } diff --git a/Maths/test/TwinPrime.test.js b/Maths/test/TwinPrime.test.js deleted file mode 100644 index fedd2909b3..0000000000 --- a/Maths/test/TwinPrime.test.js +++ /dev/null @@ -1,13 +0,0 @@ -import { twinPrime } from '../TwinPrime.js' - -describe('twinPrime', () => { - it.each([ - [3, 5], - [5, 7], - [7, -1], - [4, -1], - [17, 19] - ])('for input %i returns %i', (n, expected) => { - expect(twinPrime(n)).toBe(expected) - }) -})