diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 361d1abadd..42b4f613e3 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -19,8 +19,6 @@ jobs: npx standard npm ci npm run build --if-present - # TODO: Remove the next line when #539 is fixed. - rm Linear-Algebra/test/test.js String/LevenshteinDistance.test.js npm test env: CI: true diff --git a/Linear-Algebra/src/la_lib.js b/Linear-Algebra/src/la_lib.js index be9f507def..bba32f4aac 100644 --- a/Linear-Algebra/src/la_lib.js +++ b/Linear-Algebra/src/la_lib.js @@ -5,7 +5,8 @@ The namespace LinearAlgebra contains useful classes and functions for dealing with linear algebra under JavaScript. */ -var LinearAlgebra; +let LinearAlgebra = {}; + (function (LinearAlgebra) { /* class: Vector @@ -309,3 +310,5 @@ var LinearAlgebra; }()) // end of class Matrix LinearAlgebra.Matrix = Matrix })(LinearAlgebra || (LinearAlgebra = {})) // end of namespace LinearAlgebra + +export default LinearAlgebra diff --git a/Linear-Algebra/test/test.js b/Linear-Algebra/test/test.js index 5f1892db89..6fac6c62ae 100644 --- a/Linear-Algebra/test/test.js +++ b/Linear-Algebra/test/test.js @@ -11,7 +11,7 @@ var assert = require('assert') var fs = require('fs') // file is included here -eval(fs.readFileSync('src/la_lib.js') + '') +import LinearAlgebra from '../src/la_lib.js'; // Tests goes here // creating some vectors diff --git a/String/LevenshteinDistance.js b/String/LevenshteinDistance.js index acb09a529d..56bba291bc 100644 --- a/String/LevenshteinDistance.js +++ b/String/LevenshteinDistance.js @@ -48,4 +48,4 @@ const levenshteinDistance = (a, b) => { return distanceMatrix[b.length][a.length] } -export { levenshteinDistance } +export default levenshteinDistance diff --git a/String/LevenshteinDistance.test.js b/String/LevenshteinDistance.test.js index 777884c366..f113da2929 100644 --- a/String/LevenshteinDistance.test.js +++ b/String/LevenshteinDistance.test.js @@ -1,4 +1,4 @@ -import levenshteinDistance from './LevenshteinDistance' +import levenshteinDistance from './LevenshteinDistance.js' describe('levenshteinDistance', () => { it('should calculate edit distance between two strings', () => { @@ -14,13 +14,13 @@ describe('levenshteinDistance', () => { // Should just substitute i with o, m with g and insert e at end expect(levenshteinDistance('firm', 'forge')).toBe(3) - // Should just substitute i with s, g with i, h with t and delete f from front - expect(levenshteinDistance('fighting', 'sitting')).toBe(4) + // Should just substitute f with s, g with t and delete h + expect(levenshteinDistance('fighting', 'sitting')).toBe(3) // Should add 4 letters b, a, s and e at the beginning. expect(levenshteinDistance('ball', 'baseball')).toBe(4) // Should delete 4 letters b, a, s and e at the beginning. - expect(levenshteinDistance('baseball', 'foot')).toBe(4) + expect(levenshteinDistance('baseball', 'ball')).toBe(4) }) })