test_html_render.py::test_content_in_br still fail

Author: eoneruw

students/eoner/lesson07/html_render.py

@@ -12,10 +12,7 @@ class Element(object):
 
     def __init__(self, content=None, **kwargs):
         self.contents = [content]
-        self.attributes = ""
-        # create a string with kwargs
-        for key, value in kwargs.items():
-            self.attributes+=(' {}="{}",'.format(key, value))
+        self.attributes = kwargs
 
     def append(self, new_content):
         self.contents.append(new_content)
@@ -24,8 +21,10 @@ def render(self, out_file):
         # loop the content list
         # add tags to beginning / end
         open_tag = ["<{}".format(self.tag)]
-        if len(self.attributes) >0:
-            open_tag.append(self.attributes[:-1])
+        #if any kwargs, add them in to starting tag
+        if self.attributes!={}:
+            for k, v in self.attributes.items():
+                open_tag.append(' {}="{}"'.format(k, v))
         open_tag.append(">\n")
         out_file.write("".join(open_tag))
 
@@ -71,15 +70,24 @@ def render(self, out_file):
         # loop the content list
         # add tags to beginning / end
         open_tag = ["<{}".format(self.tag)]
-        out_file.write("".join(open_tag))        
+        if self.attributes!={}:
+            for k, v in self.attributes.items():
+                open_tag.append(' {}="{}"'.format(k, v))
         for content in self.contents:
             try:
                 if content is not None:
-                    content.render(out_file)
+                    raise TypeError
             except AttributeError:
                 out_file.write(content)
+        out_file.write("".join(open_tag))
         out_file.write(" />\n")
+    
+    def append(self, content):
+        raise TypeError
 
 class Hr(SelfClosingTag):
     tag = "hr"
-    #Hr(width=400)
+    #Hr(width=400)
+
+class Br(SelfClosingTag):
+    tag = "br"

students/eoner/lesson07/test_html_render.py

@@ -252,7 +252,24 @@ def test_hr_attr():
     file_contents = render_result(hr)
     print(file_contents)
     assert file_contents == '<hr width="400" />\n'
-    assert False
+
+    br = Br()
+    file_contents = render_result(br)
+    print(file_contents)
+    assert file_contents == "<br />\n"
+
+
+def test_content_in_br():
+    with pytest.raises(TypeError):
+        br = Br("some content")
+
+
+def test_append_content_in_br():
+    with pytest.raises(TypeError):
+        br = Br()
+        br.append("some content")
+
+    # assert False
 # #####################
 # # indentation testing
 # #  Uncomment for Step 9 -- adding indentation