chore: Fix clippy lints in Rust beta (#10050)

* Fix max compact difficulty calculation in tests

* Refactor duplicate tree checks to use if let instead of unwrap

* Add clippy allow for `unwrap_in_result` in tests

* Refactor error handling by replacing panics with Result propagation

* Add `clippy::unwrap_in_result` to `zebra-utils`

* fmt

* Remove unnecessary clone call in get_block_1 test

* Remove unused variable

* Use Amount::zero instead of try_from for zero nonnegative amount

Simplify amount initialization by replacing try_from(0) with Amount::zero()
for clarity and consistency in joinsplit and sprout pool checks

* Fix typo in comment from "Defence" to "Defense"

* Add Default derive to CompactSizeMessage struct

* Add From<SerializationError> for io::Error implementation

* Simplify `zcash_serialize_{bytes, empty_list}`

* Handle minimal height case safely in subtree validation

* Move clippy allow for unwrap_in_result inside append method

* Add From impl for Sprout NoteCommitmentTreeError in ValidateContextError

* Simplify sprout anchor tree appends using error propagation

* Improve error handling in height_from_signed_int conversions

* Add error handling for conversion and overflow checks in ZIP-317 logic

* Add explicit expect for mem_bytes length in truncate_zero_be_bytes

Author: upbqdn

tower-batch-control/tests/ed25519.rs

@@ -1,5 +1,7 @@
 //! Test batching using ed25519 verification.
 
+#![allow(clippy::unwrap_in_result)]
+
 use std::{
     mem,
     pin::Pin,

zebra-chain/src/amount/tests.rs

@@ -1,4 +1,6 @@
 //! Tests for amounts
 
+#![allow(clippy::unwrap_in_result)]
+
 mod prop;
 mod vectors;

zebra-chain/src/block/arbitrary.rs

@@ -602,9 +602,7 @@ where
                 input.set_outpoint(selected_outpoint);
                 new_inputs.push(input);
 
-                let spent_utxo = utxos
-                    .remove(&selected_outpoint)
-                    .expect("selected outpoint must have a UTXO");
+                let spent_utxo = utxos.remove(&selected_outpoint)?;
                 spent_outputs.insert(selected_outpoint, spent_utxo.utxo.output);
             }
             // otherwise, drop the invalid input, because it has no valid UTXOs to spend

zebra-chain/src/block/tests.rs

@@ -1,5 +1,7 @@
 //! Tests for Zebra blocks
 
+#![allow(clippy::unwrap_in_result)]
+
 // TODO: generate should be rewritten as strategies
 #[cfg(any(test, feature = "bench", feature = "proptest-impl"))]
 pub mod generate;

zebra-chain/src/chain_tip/tests.rs

@@ -1 +1,3 @@
+#![allow(clippy::unwrap_in_result)]
+
 mod prop;

zebra-chain/src/history_tree/tests.rs

@@ -1,4 +1,6 @@
 //! Tests for history trees
 
+#![allow(clippy::unwrap_in_result)]
+
 #[cfg(test)]
 mod vectors;

zebra-chain/src/orchard/tests.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::unwrap_in_result)]
+
 mod preallocate;
 mod prop;
 mod tree;

zebra-chain/src/parameters/checkpoint/list/tests.rs

@@ -1,5 +1,7 @@
 //! Tests for CheckpointList
 
+#![allow(clippy::unwrap_in_result)]
+
 use std::sync::Arc;
 
 use num_integer::div_ceil;

zebra-chain/src/parameters/network/subsidy.rs

@@ -712,34 +712,22 @@ pub fn height_for_halving(halving: u32, network: &Network) -> Option<Height> {
     }
 
     let slow_start_shift = i64::from(network.slow_start_shift().0);
-    let blossom_height = i64::from(
-        NetworkUpgrade::Blossom
-            .activation_height(network)
-            .expect("blossom activation height should be available")
-            .0,
-    );
+    let blossom_height = i64::from(NetworkUpgrade::Blossom.activation_height(network)?.0);
     let pre_blossom_halving_interval = network.pre_blossom_halving_interval();
     let halving_index = i64::from(halving);
 
-    let unscaled_height = halving_index
-        .checked_mul(pre_blossom_halving_interval)
-        .expect("Multiplication overflow: consider reducing the halving interval");
+    let unscaled_height = halving_index.checked_mul(pre_blossom_halving_interval)?;
 
     let pre_blossom_height = unscaled_height
         .min(blossom_height)
-        .checked_add(slow_start_shift)
-        .expect("Addition overflow: consider reducing the halving interval");
+        .checked_add(slow_start_shift)?;
 
     let post_blossom_height = 0
         .max(unscaled_height - blossom_height)
-        .checked_mul(i64::from(BLOSSOM_POW_TARGET_SPACING_RATIO))
-        .expect("Multiplication overflow: consider reducing the halving interval")
-        .checked_add(slow_start_shift)
-        .expect("Addition overflow: consider reducing the halving interval");
-
-    let height = pre_blossom_height
-        .checked_add(post_blossom_height)
-        .expect("Addition overflow: consider reducing the halving interval");
+        .checked_mul(i64::from(BLOSSOM_POW_TARGET_SPACING_RATIO))?
+        .checked_add(slow_start_shift)?;
+
+    let height = pre_blossom_height.checked_add(post_blossom_height)?;
 
     let height = u32::try_from(height).ok()?;
     height.try_into().ok()

zebra-chain/src/parameters/network/tests.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::unwrap_in_result)]
+
 mod prop;
 mod vectors;