Skip to content

Commit aa3ea88

Browse files
alan-agius4clydin
authored andcommitted
feat(@angular-devkit/build-angular): enable inlineCritical by default
BREAKING CHANGE: Critical CSS inlining is now enabled by default. If you wish to turn this off set `inlineCritical` to `false`. See: https://angular.io/guide/workspace-config#optimization-configuration
1 parent 32a0173 commit aa3ea88

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

packages/angular/cli/lib/config/schema.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -740,7 +740,7 @@
740740
"inlineCritical": {
741741
"type": "boolean",
742742
"description": "Extract and inline critical CSS definitions to improve first paint time.",
743-
"default": false
743+
"default": true
744744
}
745745
},
746746
"additionalProperties": false

packages/angular_devkit/build_angular/src/browser/schema.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484
"inlineCritical": {
8585
"type": "boolean",
8686
"description": "Extract and inline critical CSS definitions to improve first paint time.",
87-
"default": false
87+
"default": true
8888
}
8989
},
9090
"additionalProperties": false

packages/angular_devkit/build_angular/src/utils/normalize-optimization.ts

+2-4
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ export function normalizeOptimization(optimization: OptimizationUnion = false):
1919
scripts: !!optimization.scripts,
2020
styles: typeof optimization.styles === 'object' ? optimization.styles : {
2121
minify: !!optimization.styles,
22-
// inlineCritical is always false unless explictly set.
23-
inlineCritical: false,
22+
inlineCritical: !!optimization.styles,
2423
},
2524
fonts: typeof optimization.fonts === 'object' ? optimization.fonts : {
2625
inline: !!optimization.fonts,
@@ -32,8 +31,7 @@ export function normalizeOptimization(optimization: OptimizationUnion = false):
3231
scripts: optimization,
3332
styles: {
3433
minify: optimization,
35-
// inlineCritical is always false unless explictly set.
36-
inlineCritical: false,
34+
inlineCritical: optimization,
3735
},
3836
fonts: {
3937
inline: optimization,

0 commit comments

Comments
 (0)