Skip to content

Provide specific scopes in contributing guidelines #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
comewalk opened this issue Feb 23, 2017 · 3 comments · Fixed by #5121
Closed

Provide specific scopes in contributing guidelines #4967

comewalk opened this issue Feb 23, 2017 · 3 comments · Fixed by #5121

Comments

@comewalk
Copy link
Contributor

comewalk commented Feb 23, 2017

This repository runs tests on Travis CI and AppVeyor. Although checking commit message, no one provides specific scopes in CONTRIBUTING.md.

Scope

The scope could be anything specifying place of the commit change. For example
Compiler, ElementInjector, etc.

Actually validate-commit-message.js checks scopes. If someone write wrong scopes in commit message, Travis CI and AppVeyor will fail. (me, too. at build #6536)

It's about time to provide specific scopes in CONTRIBUTING.md.
It looks like below.

### Scope
The scope could be anything specifying place of the commit change.
* @angular/cli
* @ngtools/json-schema
* @ngtools/logger
* @ngtools/webpack
* packaging
* changelog

Any thought?

@clydin
Copy link
Member

clydin commented Feb 23, 2017

A documentation update is in progress.

@comewalk
Copy link
Contributor Author

@clydin sounds good 👍

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants