fix(): add conditional logic to prevent bootstrapping in protractor tests

Previously, running protractor caused a bootstrapping error because
protractor also uses NG_DEFER_BOOTSTRAP. This change monkey patches
angular.resumeBootstrap when protractor is deferring the bootstrap
so that the angular hint modules can be loaded for testing. This
fixes an already bootstrapped error received when testing with
protractor. This commit does not cause current protractor tests
to pass as the angular hint logging system is a work in progress.
The protractor tests will test for that output when the logging
is complete.

Closes #15

Author: Erin Altenhof-Long

hint.js

@@ -7,11 +7,31 @@ require('angular-hint-dom');
 require('angular-hint-directives');
 
 var allModules = ['ngHintDirectives', 'ngHintDom'];
+var isTest = false;
+if(window.name === 'NG_DEFER_BOOTSTRAP!') {
+  isTest = true;
+  var originalResumeBootstrap;
+  Object.defineProperty(angular, 'resumeBootstrap', {
+    get: function() {
+      return function(modules) {
+        return(originalResumeBootstrap.call(angular, modules.concat(loadHintModules())))
+      }
+    },
+    set: function(resumeBootstrap) {
+      originalResumeBootstrap = resumeBootstrap;
 
-window.name = 'NG_DEFER_BOOTSTRAP!';
+    }
+  });
+  console.log = function(message) {
+    var log = document.getElementById('console');
+    log.innerHTML = message;
+  }
+}
+else {
+  window.name = 'NG_DEFER_BOOTSTRAP!';
+}
 
-// determine which modules to load and resume bootstrap
-angular.element(document).ready(function() {
+function loadHintModules() {
   var selectedModules;
   var elts;
   var includeModules = function(modulesToInclude) {
@@ -20,7 +40,6 @@ angular.element(document).ready(function() {
     });
     return selected;
   };
-
   var excludeModules = function(modulesToExclude) {
     var selected = allModules.filter(function(name) {
       var notFound = true;
@@ -35,7 +54,6 @@ angular.element(document).ready(function() {
     });
     return selected;
   };
-
   elts = document.querySelectorAll('[ng-hint-include]');
   if(elts.length > 0) {
     selectedModules = includeModules(elts[0].attributes['ng-hint-include'].value.split(' '));
@@ -52,10 +70,18 @@ angular.element(document).ready(function() {
       }
     }
   }
-  if(selectedModules != undefined) {
-    angular.resumeBootstrap(selectedModules);
-  }
-  else {
-    angular.resumeBootstrap();
+  return selectedModules;
+};
+
+// determine which modules to load and resume bootstrap
+angular.element(document).ready(function() {
+  if(!isTest) {
+    var modules = loadHintModules();
+    if(modules != undefined) {
+      angular.resumeBootstrap(modules);
+    }
+    else {
+      angular.resumeBootstrap();
+    }
   }
 });

hint_test.js

@@ -1,29 +1,28 @@
 describe('angularHint', function() {
-
   describe('angular hint bootstrapping', function() {
-    it('should warn if ng-hint is called with unknown options', function() {
+    // it('should warn if ng-hint is called with unknown options', function() {
 
-    });
+    // });
 
 
-    it('should include all modules by ng-hint default', function() {
+    // it('should include all modules by ng-hint default', function() {
 
-    });
+    // });
 
 
     it('should have an inclusive mode', function() {
-      //spyOn(console, 'log');
-      browser.get('http://localhost:8080/e2e/inclusiveHint/#/inclusiveHint%3C/span%3E');
-      //expect(console.log).toHaveBeenCalled();
+      browser.get('http://localhost:8080/e2e/inclusiveHint%3C/span%3E');
+      expect(element(by.id('title')).getText()).toBe('Inclusive Hint Example');
+      expect(element(by.id('console')).getText().getText()).toBe('Angular best practices are to manipulate the DOM in the view. See: (https://github.com/angular/angular-hint-dom/blob/master/README.md) Expand to view manipulated properties and line numbers.');
     });
 
 
-    it('should have an exclusive mode', function() {
+    // it('should have an exclusive mode', function() {
 
-    });
+    // });
 
-    it('should not bootstrap if ng-hint is not included', function() {
+    // it('should not bootstrap if ng-hint is not included', function() {
 
-    });
+    // });
   });
 });