Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

Commit a7cf8b3

Browse files
mattlavalleeSomeKittens
authored andcommitted
fix(Module): Differentiate between get and set
Module did not differentiate between a get and set of the module resulting in incorrect errors about a module being defined more than once
1 parent 8885e0d commit a7cf8b3

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/modules/modules.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,11 @@ angular.module = function(name, requiresOriginal) {
2121
modules[name] = module;
2222
hasNameSpace(name);
2323
var modToCheck = getModule(name, true);
24+
//check arguments to determine if called as setter or getter
25+
var modIsSetter = arguments.length > 1;
2426

25-
if(modToCheck && modToCheck.requiresOriginal !== module.requiresOriginal) {
27+
28+
if(modToCheck && modToCheck.requiresOriginal !== module.requiresOriginal && modIsSetter) {
2629
if(!modData.createdMulti[name]) {
2730
modData.createdMulti[name] = [getModule(name,true)];
2831
}

0 commit comments

Comments
 (0)