Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

Commit e7bab91

Browse files
btfordbtford
committed
refactor(e2e): move logging hack into separate file
1 parent 674e90a commit e7bab91

File tree

8 files changed

+27
-19
lines changed

8 files changed

+27
-19
lines changed

‎e2e/allHint/index.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,19 @@
11
<!doctype html>
2-
<html ng-app="sampleAllHint">
2+
<html ng-app="sampleAllHint" ng-hint>
33
<head>
44
<meta charset="utf-8">
55
<title>Angular Hint Example</title>
66

77
<script src="../../bower_components/angular/angular.js"></script>
88
<script src="../../bower_components/angular-route/angular-route.js"></script>
99
<script src="../../dist/hint.js"></script>
10+
<script src="../util.js"></script>
1011

1112
<script src="app.js"></script>
1213
<script src="app-controller.js"></script>
1314

1415
</head>
15-
<body ng-hint>
16+
<body>
1617
<div ng-view></div>
1718
</body>
1819
</html>

‎e2e/exclusiveHint/index.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
<!doctype html>
2-
<html ng-app="sampleExclusiveHint">
2+
<html ng-app="sampleExclusiveHint" ng-hint-exclude="dom">
33
<head>
44
<meta charset="utf-8">
55
<title>Angular Exclusive Hint Example</title>
66

77
<script src="../../bower_components/angular/angular.js"></script>
88
<script src="../../bower_components/angular-route/angular-route.js"></script>
99
<script src="../../dist/hint.js"></script>
10+
<script src="../util.js"></script>
1011

1112
<script src="app.js"></script>
1213
<script src="app-controller.js"></script>
13-
1414
</head>
15-
<body ng-hint-exclude="dom">
15+
<body>
1616
<div ng-view></div>
1717
</body>
18-
</html>
18+
</html>

‎e2e/inclusiveHint/index.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
<script src="../../bower_components/angular/angular.js"></script>
88
<script src="../../bower_components/angular-route/angular-route.js"></script>
99
<script src="../../dist/hint.js"></script>
10+
<script src="../util.js"></script>
1011

1112
<script src="app.js"></script>
1213
<script src="app-controller.js"></script>

‎e2e/manualBootstrap/index.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
<script src="../../bower_components/angular/angular.js"></script>
88
<script src="../../bower_components/angular-route/angular-route.js"></script>
99
<script src="../../dist/hint.js"></script>
10+
<script src="../util.js"></script>
1011

1112
</head>
1213
<body>

‎e2e/manualBootstrapAlternative/index.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
<script src="../../bower_components/angular/angular.js"></script>
88
<script src="../../bower_components/angular-route/angular-route.js"></script>
99
<script src="../../dist/hint.js"></script>
10+
<script src="../util.js"></script>
1011

1112
</head>
1213
<body>

‎e2e/noHint/index.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
<script src="../../bower_components/angular/angular.js"></script>
88
<script src="../../bower_components/angular-route/angular-route.js"></script>
99
<script src="../../dist/hint.js"></script>
10+
<script src="../util.js"></script>
1011

1112
<script src="app.js"></script>
1213
<script src="app-controller.js"></script>

‎e2e/util.js

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
2+
// For test cases, log the console to an HTML element that can be retrieved by protractor
3+
console.groupCollapsed = function(message) {
4+
var log = document.getElementById('console');
5+
log.innerHTML += message;
6+
};
7+
8+
console.group = function(message) {
9+
var log = document.getElementById('console');
10+
log.innerHTML += message;
11+
};
12+
13+
console.log = function(message) {
14+
var log = document.getElementById('console');
15+
log.innerHTML += message;
16+
};

‎hint.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,19 +24,6 @@ if(window.name === 'NG_DEFER_BOOTSTRAP!') {
2424

2525
}
2626
});
27-
//For test cases, log the console to an HTML element that can be retrieved by protractor.
28-
console.groupCollapsed = function(message) {
29-
var log = document.getElementById('console');
30-
log.innerHTML += message;
31-
}
32-
console.group = function(message) {
33-
var log = document.getElementById('console');
34-
log.innerHTML += message;
35-
}
36-
console.log = function(message) {
37-
var log = document.getElementById('console');
38-
log.innerHTML += message;
39-
}
4027
}
4128
//If this is not a test, defer bootstrapping
4229
else {

0 commit comments

Comments
 (0)