Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Commit 4f77b10

Browse files
committed
check-deploy task now can actually deploy
1 parent d0bfed6 commit 4f77b10

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

gulpfile.js

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ var exec = require('child_process').exec;
1818
var execPromise = Q.denodeify(exec);
1919
var prompt = require('prompt');
2020

21+
// TODO:
22+
// 1. Think about using runSequence
23+
// 2. Think about using spawn instead of exec in case of long error messages.
24+
2125

2226
var docShredder = require('./public/doc-shredder/doc-shredder');
2327

@@ -38,13 +42,6 @@ var _excludeMatchers = _excludePatterns.map(function(excludePattern){
3842
return new Minimatch(excludePattern)
3943
});
4044

41-
/*
42-
Within this repo generated files are checked in so that we can avoid running the
43-
shredder over the entire _examples dir each time someone refreshes the repo
44-
( the ‘shred-devguide-examples’ gulp task). The gulp ‘serve-and-watch’ shredder is only
45-
a ‘partial’ shredder. It only shred’s files in directories changed during
46-
the current session.
47-
*/
4845

4946
gulp.task('help', taskListing.withFilters(function(taskName) {
5047
var isSubTask = taskName.substr(0,1) == "_";
@@ -97,7 +94,6 @@ gulp.task('build-api-docs', ['_shred-api-examples'], function() {
9794
return buildApiDocs();
9895
});
9996

100-
10197
gulp.task('_shred-devguide-examples', ['_shred-clean-devguide'], function() {
10298
return docShredder.shred( _devguideShredOptions);
10399
});
@@ -120,7 +116,6 @@ gulp.task('_build-shred-maps', function() {
120116
return build-shred-maps(true);
121117
});
122118

123-
124119
gulp.task('git-changed-examples', ['_shred-devguide-examples'], function(){
125120
var after, sha, messageSuffix;
126121
if (argv.after) {
@@ -168,14 +163,19 @@ gulp.task('git-changed-examples', ['_shred-devguide-examples'], function(){
168163
});
169164

170165
gulp.task('check-deploy', function() {
171-
return execPromise(['npm run harp -- compile . ./deploy'], {}).then(function() {
172-
execPromise('npm run live-server ./deploy');
166+
console.log('running harp compile...');
167+
return execPromise('npm run harp -- compile . ./www', {}).then(function() {
168+
execPromise('npm run live-server ./www');
173169
return askDeploy();
174170
}).then(function(shouldDeploy) {
175171
if (shouldDeploy) {
176-
console.log("Sorry! Deploy to Firebase has not yet been implemented.")
172+
console.log('deploying...');
173+
return execPromise('firebase deploy');
174+
} else {
175+
return ['Not deploying'];
177176
}
178-
return;
177+
}).then(function(s) {
178+
console.log(s.join(''));
179179
});
180180
});
181181

0 commit comments

Comments
 (0)