Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 190bc1d

Browse files
committed
fixup! fix(ngAria.ngClick): restrict preventDefault on space / enter to non-interactive elements
1 parent 4be80ae commit 190bc1d

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

test/ngAria/ariaSpec.js

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -959,9 +959,7 @@ describe('$aria', function() {
959959
function createHTML(type) {
960960
var html = '<' + type + '>';
961961

962-
if (type === 'INPUT' || 'TYPE' === 'A') {
963-
return html;
964-
}
962+
if (type === 'INPUT' || 'TYPE' === 'A') return html;
965963

966964
return html + '</' + type + '>';
967965
}
@@ -975,10 +973,15 @@ describe('$aria', function() {
975973
var interactiveElement = element.find(elementType);
976974

977975
// Use browserTrigger because it supports event bubbling
976+
// 13 Enter
978977
browserTrigger(interactiveElement, 'keydown', {cancelable: true, bubbles: true, keyCode: 13});
979-
browserTrigger(interactiveElement, 'keydown', {cancelable: true, bubbles: true, keyCode: 32});
978+
expect(clickEvents).toEqual([elementType.toLowerCase() + '(false)']);
979+
980+
clickEvents = [];
980981

981-
expect(clickEvents).toEqual([elementType.toLowerCase() + '(false)', elementType.toLowerCase() + '(false)']);
982+
// 32 Space
983+
browserTrigger(interactiveElement, 'keydown', {cancelable: true, bubbles: true, keyCode: 32});
984+
expect(clickEvents).toEqual([elementType.toLowerCase() + '(false)']);
982985
}
983986
);
984987

0 commit comments

Comments
 (0)