bug(many): duplicate code for exposing overlays for modals #26853
Labels
Accessibility
This issue is related to accessibility (a11y)
area: many
Area label for issues related to many components
P4
A relatively minor issue that is not relevant to core functions
refactoring
This issue is related to a refactoring
Is this a regression?
The previous version in which this bug was not present was
No response
Description
We have duplicated code for logic for exposing overlays to modals. some browsers won't expose the accessibility node of the overlay if there is an
aria-modal
and the live element is outside of it. This method works around the issue by pointing thearia-owns
of all modals to the live element.Action item to consider de-duplicating this with the
LiveAnnouncer
and any other occurrences.Note that the selector here is limited to CDK overlays at the moment in order to reduce the section of the DOM we need to look through. This should cover all the cases we support, but the selector can be expanded if it turns out to be too narrow.
Reproduction
Search codebase for TODOS references this issue report.
Expected Behavior
no occurrences
Actual Behavior
multiple occurrences
Environment
N/A
The text was updated successfully, but these errors were encountered: