Skip to content

bug(many): duplicate code for exposing overlays for modals #26853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task
zarend opened this issue Mar 29, 2023 · 0 comments
Open
1 task

bug(many): duplicate code for exposing overlays for modals #26853

zarend opened this issue Mar 29, 2023 · 0 comments
Labels
Accessibility This issue is related to accessibility (a11y) area: many Area label for issues related to many components P4 A relatively minor issue that is not relevant to core functions refactoring This issue is related to a refactoring

Comments

@zarend
Copy link
Contributor

zarend commented Mar 29, 2023

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

We have duplicated code for logic for exposing overlays to modals. some browsers won't expose the accessibility node of the overlay if there is an aria-modal and the live element is outside of it. This method works around the issue by pointing the aria-owns of all modals to the live element.

Action item to consider de-duplicating this with the LiveAnnouncer and any other occurrences.

Note that the selector here is limited to CDK overlays at the moment in order to reduce the section of the DOM we need to look through. This should cover all the cases we support, but the selector can be expanded if it turns out to be too narrow.

Reproduction

Search codebase for TODOS references this issue report.

git grep 'TODO(http://github.com/angular/components/issues/26853)'; git grep '#26853';

Expected Behavior

no occurrences

Actual Behavior

multiple occurrences

Environment

N/A

@zarend zarend added Accessibility This issue is related to accessibility (a11y) P4 A relatively minor issue that is not relevant to core functions area: many Area label for issues related to many components labels Mar 29, 2023
@jelbourn jelbourn added the refactoring This issue is related to a refactoring label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility This issue is related to accessibility (a11y) area: many Area label for issues related to many components P4 A relatively minor issue that is not relevant to core functions refactoring This issue is related to a refactoring
Projects
None yet
Development

No branches or pull requests

2 participants