Add schema file #13
Merged
Add schema file #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A schema file might help remembering the new changelog format.
vy
requested changes
Jan 22, 2023
There was a problem hiding this comment.
@ppkarwasz, this will be great addition! Thanks!
I have dropped some minor remarks. I will appreciate it if you can address them.
| @@ -18,4 +18,8 @@ target/ | |||
| *.iml | |||
| *.iws | |||
| /out | |||
| dependency-reduced-pom.xml | |||
| .flattened-pom.xml | |||
There was a problem hiding this comment.
Is this necessary? I tried to make sure flatten-maven-plugin always outputs to target, have I missed something?
There was a problem hiding this comment.
Maybe not, I just replaced dependency-reduced-pom.xml with .flattened-pom.xml. Didn't check if this applies.
|
@ppkarwasz, shouldn't we use two separate XSDs: one for |
Co-authored-by: Volkan Yazıcı <[email protected]>
Co-authored-by: Volkan Yazıcı <[email protected]>
Co-authored-by: Volkan Yazıcı <[email protected]>
* adds a `schemaVersion` attribute, * replaces `ID` with a more liberal `string`, * removes `TBD` as date value.
vy
added a commit
that referenced
this pull request
Jan 24, 2023
vy
added a commit
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A schema file might help remembering the new changelog format.