Skip to content

ModbusServer::writeInputRegisters not implemented #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jlucas2019 opened this issue Oct 21, 2019 · 2 comments · Fixed by #20
Closed

ModbusServer::writeInputRegisters not implemented #18

jlucas2019 opened this issue Oct 21, 2019 · 2 comments · Fixed by #20
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@jlucas2019
Copy link

jlucas2019 commented Oct 21, 2019

Hello,

When trying to use the function ModbusServer::writeInputRegisters got the following error:

/tmp/ccmQwHO6.ltrans1.ltrans.o: In function `main':
<artificial>:(.text.startup+0x996): undefined reference to `ModbusServer::writeInputRegisters(int, unsigned int*, int)'
collect2: error: ld returned 1 exit status
exit status 1
Error compiling for board Arduino/Genuino Mega or Mega 2560.

The function is documented under the official ArduinoModbus library site:
https://www.arduino.cc/en/ArduinoModbus/ModbusServerwriteInputRegisters

However, looking inside the code, the function seems to be defined in ModbusServer.h, but not implemented in ModbusServer.cpp.

Is there any specific reason for this or is just a lapse?

@sandeepmistry
Copy link
Contributor

Hi @jlucas2019,

Thanks for bringing this to our attention!

Is there any specific reason for this or is just a lapse?

This was just a lapse. I've opened pull request #20 to correct this. It would be great if you could try out the changes and provide your feedback.

@terrasmart
Copy link

terrasmart commented Jan 23, 2020

Hello @sandeepmistry

Is the WriteMultipleHoldingRegisters function n.16 (10H) implemented for the ModbusClient Class ?

I don't find it.

I need to use a 10H function because I have a sensor which accept only functions 03 and 16.

Please can you help ? it's quite urgent. many thanks !

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Oct 6, 2023
@per1234 per1234 changed the title ModbusServer::writeInputRegisters not implemented? ModbusServer::writeInputRegisters not implemented Oct 6, 2023
@per1234 per1234 self-assigned this Oct 6, 2023
@per1234 per1234 closed this as completed Oct 6, 2023
@per1234 per1234 added the conclusion: resolved Issue was resolved label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
4 participants