From 3781023e3d8650d4ac881e43dde686345c5da425 Mon Sep 17 00:00:00 2001 From: Self Not Found Date: Sat, 17 Dec 2022 13:56:54 +0800 Subject: [PATCH 1/2] Remove trailing colon when parsing the protocol from URL --- arduino-ide-extension/src/common/protocol/config-service.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arduino-ide-extension/src/common/protocol/config-service.ts b/arduino-ide-extension/src/common/protocol/config-service.ts index adc5d9aa0..31289d161 100644 --- a/arduino-ide-extension/src/common/protocol/config-service.ts +++ b/arduino-ide-extension/src/common/protocol/config-service.ts @@ -60,8 +60,10 @@ export namespace Network { try { // Patter: PROTOCOL://USER:PASS@HOSTNAME:PORT/ const { protocol, hostname, password, username, port } = new URL(raw); + // protocol in URL object contains a trailing colon + const newProtocol = protocol.replace(/:$/, ''); return { - protocol, + newProtocol, hostname, password, username, From 2a32cf2f18182a66d86247cfbfde48fd0f042fd5 Mon Sep 17 00:00:00 2001 From: Self Not Found Date: Sat, 17 Dec 2022 14:15:21 +0800 Subject: [PATCH 2/2] Fix bug --- arduino-ide-extension/src/common/protocol/config-service.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arduino-ide-extension/src/common/protocol/config-service.ts b/arduino-ide-extension/src/common/protocol/config-service.ts index 31289d161..d02f92770 100644 --- a/arduino-ide-extension/src/common/protocol/config-service.ts +++ b/arduino-ide-extension/src/common/protocol/config-service.ts @@ -63,7 +63,7 @@ export namespace Network { // protocol in URL object contains a trailing colon const newProtocol = protocol.replace(/:$/, ''); return { - newProtocol, + protocol: newProtocol, hostname, password, username,