feat(golang-rewrite): add support for shim templates resolution #2076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stratus3D
force-pushed
the
tb/shim-template-support
branch
2 times, most recently
from
88d542a to
1bf543a
Compare
Stratus3D
force-pushed
the
tb/shim-template-support
branch
from
1bf543a to
c3909ec
Compare
augustobmoura
approved these changes
May 6, 2025
Member
There was a problem hiding this comment.
Added an explanation on #2067 (comment) about the ExecutablePaths change.
I think the auto-shim template in asdf-nodejs should work even without adding shims to PATH, but it is better to test it to be sure
Stratus3D
force-pushed
the
tb/shim-template-support
branch
from
c3909ec to
15d7523
Compare
Member
Author
|
This PR has been updated to add the changes back into |
Stratus3D
force-pushed
the
tb/shim-template-support
branch
from
15d7523 to
169b73b
Compare
This was referenced May 7, 2025
Merged
This was referenced May 14, 2025
Closed
Stratus3D
added a commit
that referenced
this pull request
May 16, 2025
Co-authored-by: Augusto Moura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based #2067, only changes are to fix linter warnings.