From 57a234f40ce4705fcc75b368ea492536442d41c6 Mon Sep 17 00:00:00 2001 From: Sean Gates Date: Thu, 18 May 2017 11:01:36 -0600 Subject: [PATCH 1/2] Creating a variable for the length property; Fixing the `for` loop snippet to use a variable for the length property, and then evaluate the new variable instead of reading the property. --- snippets/language-javascript.cson | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/snippets/language-javascript.cson b/snippets/language-javascript.cson index 8f523430..346b3e08 100644 --- a/snippets/language-javascript.cson +++ b/snippets/language-javascript.cson @@ -28,7 +28,7 @@ 'body': 'else if (${1:true}) {\n\t$2\n}' 'for': 'prefix' : 'for' - 'body' : 'for (var ${2:i} = 0; ${2:i} < ${1:array}.length; ${2:i}++) {\n\t${1:array}[${2:i}]$3\n}' + 'body' : 'for (var ${2:i} = 0, ${3:len} = ${1:array}.length; ${2:i} < ${3:len}; ${2:i}++) {\n\t${1:array}[${2:i}]$4\n}' 'for in': 'prefix': 'forin' 'body': 'for (var ${1:variable} in ${2:object}) {\n\t${3:if (${2:object}.hasOwnProperty(${1:variable})) {\n\t\t$4\n\t\\}}\n}' From f15511d8af73737e781496d0ea6f0e1edb53a02c Mon Sep 17 00:00:00 2001 From: Sean Gates Date: Thu, 18 May 2017 11:04:02 -0600 Subject: [PATCH 2/2] Use the += 1 for counting iterations Explicitly add with a `1` instead of evaluating the variable twice and adding after evaluation. --- snippets/language-javascript.cson | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/snippets/language-javascript.cson b/snippets/language-javascript.cson index 346b3e08..ae373836 100644 --- a/snippets/language-javascript.cson +++ b/snippets/language-javascript.cson @@ -28,7 +28,7 @@ 'body': 'else if (${1:true}) {\n\t$2\n}' 'for': 'prefix' : 'for' - 'body' : 'for (var ${2:i} = 0, ${3:len} = ${1:array}.length; ${2:i} < ${3:len}; ${2:i}++) {\n\t${1:array}[${2:i}]$4\n}' + 'body' : 'for (var ${2:i} = 0, ${3:len} = ${1:array}.length; ${2:i} < ${3:len}; ${2:i} += 1) {\n\t${1:array}[${2:i}]$4\n}' 'for in': 'prefix': 'forin' 'body': 'for (var ${1:variable} in ${2:object}) {\n\t${3:if (${2:object}.hasOwnProperty(${1:variable})) {\n\t\t$4\n\t\\}}\n}'