Remove trailing slash in x-amz-credential for s3 presigned post #4081
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarrettBeatty
approved these changes
Oct 27, 2025
muhammad-othman
approved these changes
Oct 27, 2025
|
dry run succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #4069
Motivation and Context
Removes trailing slash from
x-amz-credential. We do this for normal SigV4 signing, looks like we just added a trailing slash unintentionally when implementing signing for presigned post.Testing
Dry-run 66bf4a77-4329-4dc2-8282-947345459739 in progress.
I didn't add additional tests because we already have so many for presigned post. I'm making the assumption that if those pass then we are covered.
Screenshots (if appropriate)
Types of changes
Checklist
License