Skip to content

Commit 3a9929d

Browse files
SaintPatrckclaude
andcommitted
Align version extraction regex with Fastlane pattern
Updates workflow regex to match the pattern used in Fastlane's setBuildVersionInfo lane for consistency across the codebase. Before: regex='appVersionName = "([^"]+)"' After: regex='appVersionName = "(.+)"' Both patterns work correctly for standard version strings, but using the same pattern as Fastlane improves maintainability and reduces potential confusion. Addresses Finding 1 from code review of PR #6181. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 80fb032 commit 3a9929d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/build-testharness.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ jobs:
101101
versionCode:"$VERSION_CODE" \
102102
versionName:"$VERSION_NAME_INPUT"
103103
104-
regex='appVersionName = "([^"]+)"'
104+
regex='appVersionName = "(.+)"'
105105
if [[ "$(cat gradle/libs.versions.toml)" =~ $regex ]]; then
106106
VERSION_NAME="${BASH_REMATCH[1]}"
107107
fi

0 commit comments

Comments
 (0)