fix($compile): copy expandostore data into replaced nodes

Before this patch, with modern versions of jQuery being used, the
element data cache was not being copied over into the new element
when replacing an asynchronous directive's compile node with its
template. This caused an issue where the element passed into a
post link function's scope() method would return the incorrect
scope.

The test which is added passes regardless of the change in jQuery
1.10.2, which is currently checked into the tree, but fails without
the change in jQuery 2.0.3.

Fixes angular#5099

Author: caitp

src/ng/compile.js

@@ -1864,7 +1864,9 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
       var firstElementToRemove = elementsToRemove[0],
           removeCount = elementsToRemove.length,
           parent = firstElementToRemove.parentNode,
-          i, ii;
+          i, ii, data;
+
+      data = elementsToRemove.data();
 
       if ($rootElement) {
         for(i = 0, ii = $rootElement.length; i < ii; i++) {
@@ -1900,6 +1902,8 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
 
       elementsToRemove[0] = newNode;
       elementsToRemove.length = 1;
+
+      elementsToRemove.data(data);
     }
 
 

test/ng/compileSpec.js

@@ -1391,6 +1391,31 @@ describe('$compile', function() {
             expect(element.html()).toContain('i = 1');
           });
         });
+
+        it('should copy compileNode data into linkNode\'s data', function() {
+          module(function($compileProvider) {
+            $compileProvider.directive('tplDir', function(log) {
+              return {
+                scope: true,
+                templateUrl: 'tplDir.html',
+                replace: true,
+                link: function(scope, element) {
+                  log(scope.$id);
+                  log(element.scope().$id);
+                }
+              };
+            });
+          });
+          inject(function($compile, $rootScope, $templateCache, log) {
+            $templateCache.put('tplDir.html', '<div></div>');
+            element = $compile('<div tpl-dir></div>')($rootScope);
+            $rootScope.$digest();
+            var $log = log.toArray();
+            expect($log.length).toBe(2);
+            console.log($log[0], $log[1]);
+            expect($log[0]).toBe($log[1]);
+          });
+        });
       });