Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Use polling based login flow #1

Closed
ammario opened this issue Apr 18, 2020 · 1 comment
Closed

Use polling based login flow #1

ammario opened this issue Apr 18, 2020 · 1 comment

Comments

@ammario
Copy link
Member

ammario commented Apr 18, 2020

The existing localhost redirect solutions breaks when the browser is running on a different network than the command line (like in Coder Enterprise).

Instead, the CLI should publish a token to CE and link the browser to authenticate that token, then store that token locally. This is more secure too since the local token is different than the browser token.

A minimal RFC in the enterprise product should lay out the API in more detail first.

@cmoog
Copy link
Contributor

cmoog commented Mar 22, 2021

The UX problem is fixed now.

@cmoog cmoog closed this as completed Mar 22, 2021
deansheather pushed a commit that referenced this issue Oct 6, 2021
* allow coder login for WSL (#1)

Co-authored-by: Armin <[email protected]>

* use constants for runtime.GOOS

* update lint errors

Co-authored-by: Armin <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants