Skip to content

Commit d94e7c7

Browse files
committed
Merge branch 'angular_next' of github.com:cloudinary/cloudinary_angular into angular_next
2 parents f8fa3b2 + 364a0bf commit d94e7c7

File tree

5 files changed

+35
-34
lines changed

5 files changed

+35
-34
lines changed

CONTRIBUTING.md

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ Contributions are welcome and greatly appreciated!
44

55
## Reporting a bug
66

7-
- Ensure that the bug was not already reported by searching in GitHub under [Issues](https://github.com/cloudinary/cloudinary-angular-2/issues) and the Cloudinary [Support forms](https://support.cloudinary.com).
8-
- If you're unable to find an open issue addressing the problem, [open a new one](https://github.com/cloudinary/cloudinary-angular-2/issues/new).
7+
- Ensure that the bug was not already reported by searching in GitHub under [Issues](https://github.com/cloudinary/cloudinary_angular/issues) and the Cloudinary [Support forms](https://support.cloudinary.com).
8+
- If you're unable to find an open issue addressing the problem, [open a new one](https://github.com/cloudinary/cloudinary_angular/issues/new).
99
Be sure to include a **title and clear description**, as much relevant information as possible, and a **code sample** or an **executable test case** demonstrating the expected behavior that is not occurring.
1010
- If you require assistance in the implementation of the Cloudinary Angular SDK please [submit a support request](https://support.cloudinary.com/hc/en-us/requests/new) in the Cloudinary web site.
1111

@@ -14,7 +14,7 @@ Contributions are welcome and greatly appreciated!
1414
We would love to hear your requests!
1515
Please be aware that some features may not be applicable to all users.
1616

17-
- Open a GitHub [issue](https://github.com/cloudinary/cloudinary-angular-2/issues/new) describing the benefits (and possible drawbacks) of the requested feature
17+
- Open a GitHub [issue](https://github.com/cloudinary/cloudinary_angular/issues/new) describing the benefits (and possible drawbacks) of the requested feature
1818

1919
## Fixing a bug / Implementing a new feature
2020

@@ -29,21 +29,22 @@ When contributing code, either to fix a bug or to implement a new feature, pleas
2929

3030
#### Fork the Project
3131

32-
Fork [project on Github](https://github.com/cloudinary/cloudinary-angular-2) and check out your copy.
32+
Fork [project on Github](https://github.com/cloudinary/cloudinary_angular) and check out your copy.
3333

3434
```
35-
git clone https://github.com/contributor/cloudinary_ng.git
36-
cd cloudinary_ng
37-
git remote add upstream https://github.com/cloudinary/cloudinary-angular-2.git
35+
git clone https://github.com/contributor/cloudinary_angular.git
36+
cd cloudinary_angular
37+
git checkout angular_next
38+
git remote add upstream https://github.com/cloudinary/cloudinary_angular.git
3839
```
3940

4041
#### Create a Topic Branch
4142

4243
Make sure your fork is up-to-date and create a topic branch for your feature or bug fix.
4344

4445
```
45-
git checkout master
46-
git pull upstream master
46+
git checkout angular_next
47+
git pull upstream angular_next
4748
git checkout -b my-feature-branch
4849
```
4950
#### Rebase
@@ -52,7 +53,7 @@ If you've been working on a change for a while, rebase with upstream/master.
5253

5354
```
5455
git fetch upstream
55-
git rebase upstream/master
56+
git rebase upstream/angular_next
5657
git push origin my-feature-branch -f
5758
```
5859

@@ -99,10 +100,10 @@ git push origin my-feature-branch
99100

100101
#### Make a Pull Request
101102

102-
Go to https://github.com/contributor/cloudinary_ng and select your feature branch. Click the 'Pull Request' button and fill out the form.
103+
Go to https://github.com/contributor/cloudinary_angular and select your feature branch. Click the 'Pull Request' button and fill out the form.
103104
Pull requests are usually reviewed within a few days.
104105

105-
Ensure the PR description clearly describes the problem and solution. Include the relevant issue number if applicable.
106+
Ensure that the PR title starts with "[angular_next]" and that the PR description clearly describes the problem and solution. Include the relevant issue number if applicable.
106107

107108
#### Check on Your Pull Request
108109

README.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ The SDK serves as a layer on top of one of Cloudinary's Javascript libraries:
2727
## Installation ######################################################################
2828

2929
```shell
30-
npm install cloudinary_ng --save
30+
npm install @cloudinary/angular --save
3131
```
3232

3333
## Setup ######################################################################
@@ -58,7 +58,7 @@ Example Coudinary configuration in your application's module definition:
5858

5959
```javascript
6060
import { NgModule } from '@angular/core';
61-
...
61+
// ...
6262
import { CloudinaryModule, CloudinaryConfiguration, provideCloudinary } from 'cloudinary-ng';
6363

6464
@NgModule({
@@ -68,19 +68,19 @@ import { CloudinaryModule, CloudinaryConfiguration, provideCloudinary } from 'cl
6868
providers: [
6969
provideCloudinary(require('cloudinary-core'), { cloud_name: 'your_cloud_name' } as CloudinaryConfiguration)
7070
],
71-
bootstrap: [...]
71+
bootstrap: [/* ... */]
7272
})
7373
export class AppModule { }
7474
```
7575

7676
See [samples folder](samples) for a complete reference project.
7777

78-
### - Creating new image tags with cl-image & cl-transformation ##################################
78+
### Creating new image tags with cl-image & cl-transformation ##################################
7979

8080
The [cl-image](src/cloudinary-image.component.ts) component generates an `<image>` tag with requested transformation, type, and format.
8181
The image tag can contain optional `<cl-transformation>` tags that will be used as chained transformations:
8282

83-
```javascript
83+
```html
8484
<cl-image public-id="readme" class="thumbnail inline" angle="20" format="jpg">
8585
<cl-transformation height="150" width="150" crop="fill" effect="sepia" radius="20"></cl-transformation>
8686
<cl-transformation overlay="text:arial_60:readme" gravity="north" y="20"></cl-transformation>
@@ -89,29 +89,29 @@ The image tag can contain optional `<cl-transformation>` tags that will be used
8989

9090
Will be compiled by Angular to:
9191

92-
```javascript
92+
```html
9393
<cl-image _ngcontent-ywn-2="" public-id="readme" class="thumbnail inline" format="jpg" angle="20" ng-reflect-public-id="readme">
9494
<img src="http://res.cloudinary.com/{your_cloud_name}/image/upload/c_fill,e_sepia,h_150,r_20,w_150/g_north,l_text:arial_60:readme,y_20/a_20/readme.jpg">
9595
</cl-image>
9696
```
9797

98-
### - Creating new video tags with cl-video & cl-transformation ##################################
98+
### Creating new video tags with cl-video & cl-transformation ##################################
9999

100100
The [cl-video](src/cloudinary-video.component.ts) component generates a `<video>` tag with requested transformation, type, and format.
101101

102102
The generated `<video>` is created with configurable child `<source>` elements for all relevant formats supported by web browsers (`webm`, `mp4` and `ogv`), as well as a poster thumbnail image.
103103

104104
The video tag can contain optional `<cl-transformation>` tags that will be used as chained transformations:
105105

106-
```javascript
106+
```html
107107
<cl-video cloud-name="my_other_cloud" public-id="watchme" secure="true" class="my-videos">
108108
<cl-transformation overlay="text:arial_60:watchme" gravity="north" y="20"></cl-transformation>
109109
</cl-video>
110110
```
111111

112112
Will be compiled by Angular to:
113113

114-
```javascript
114+
```html
115115
<video class="my-videos" public-id="watchme" ng-reflect-public-id="watchme"
116116
poster="https://res.cloudinary.com/my_other_cloud/video/upload/g_north,l_text:arial_60:watchme,y_20/watchme.jpg">
117117
<source src="https://res.cloudinary.com/my_other_cloud/video/upload/g_north,l_text:arial_60:watchme,y_20/watchme.webm" type="video/webm">
@@ -125,7 +125,7 @@ You can update attributes dynamically for `<cl-image>` and `<cl-video>` elements
125125
new transformations.
126126

127127
The following example from the sample projects demonstrates setting the opacity to 50% when hovering on top of an element:
128-
```javascript
128+
```html
129129
<cl-image
130130
public-id={{photo.public_id}}
131131
(mouseenter)="photo.isMouseOver = true"
@@ -138,13 +138,13 @@ The following example from the sample projects demonstrates setting the opacity
138138

139139
These directives transform the given URI to a cloudinary URL. For example:
140140

141-
```javascript
141+
```html
142142
<img clSrc="http://cloudinary.com/images/logo.png" type="fetch" fetch-format="auto" quality="auto">
143143
```
144144

145145
Will be compiled by Angular to:
146146

147-
```javascript
147+
```html
148148
<img clSrc="http://cloudinary.com/images/logo.png" fetch-format="auto" quality="auto" type="fetch" ng-reflect-clSrc="http://cloudinary.com/images/logo.png"
149149
src="http://res.cloudinary.com/{your_cloud_name}/image/fetch/f_auto,q_auto/http://cloudinary.com/images/logo.png">
150150
```
@@ -203,7 +203,7 @@ Additional resources are available at:
203203

204204
## Support #######################################################################
205205

206-
You can [open an issue through GitHub](https://github.com/cloudinary/cloudinary_ng/issues).
206+
You can [open an issue through GitHub](https://github.com/cloudinary/cloudinary_angular/issues).
207207

208208
Contact us [https://cloudinary.com/contact](https://cloudinary.com/contact)
209209

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@cloudinary/angular",
3-
"version": "1.0.0-rc1",
4-
"description": "The formal Cloudinary-Angular SDK to enhance your applications with image and video components powered by Cloudinary",
3+
"version": "2.0.0-rc1",
4+
"description": "The formal Cloudinary Angular SDK to enhance your applications with image and video components powered by Cloudinary",
55
"keywords": [
66
"cloudinary",
77
"angular",
@@ -34,14 +34,14 @@
3434
},
3535
"repository": {
3636
"type": "git",
37-
"url": "git://github.com/cloudinary/cloudinary-angular-2.git"
37+
"url": "git://github.com/cloudinary/cloudinary_angular.git"
3838
},
3939
"author": "Cloudinary",
4040
"license": "MIT",
4141
"bugs": {
42-
"url": "https://github.com/cloudinary/cloudinary-angular-2/issues"
42+
"url": "https://github.com/cloudinary/cloudinary_angular/issues"
4343
},
44-
"homepage": "https://github.com/cloudinary/cloudinary-angular-2",
44+
"homepage": "https://github.com/cloudinary/cloudinary_angular",
4545
"dependencies": {
4646
"@angular/common": "^2.2.4",
4747
"@angular/core": "^2.2.4",

samples/photo_album/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"@angular/platform-browser": "^2.3.0",
1414
"@angular/platform-browser-dynamic": "^2.3.0",
1515
"@angular/router": "^3.2.3",
16-
"@cloudinary/angular": "^1.0.0-rc1",
16+
"@cloudinary/angular": "^2.0.0-rc1",
1717
"cloudinary-core": "^2.1.9",
1818
"core-js": "^2.4.1",
1919
"ng2-file-upload": "^1.1.4-2",
@@ -42,4 +42,4 @@
4242
"start": "webpack-dev-server --open",
4343
"start:e2e": "webpack-dev-server"
4444
}
45-
}
45+
}

samples/photo_album_with_jquery/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"@angular/platform-browser-dynamic": "^2.3.0",
1414
"@angular/router": "^3.0.2",
1515
"blueimp-file-upload": "^9.11.2",
16-
"@cloudinary/angular": "^1.0.0-rc1",
16+
"@cloudinary/angular": "^2.0.0-rc1",
1717
"cloudinary-jquery-file-upload": "^2.1.9",
1818
"core-js": "^2.4.1",
1919
"jquery": ">=1.9",
@@ -35,4 +35,4 @@
3535
"tsc": "tsc",
3636
"tsc:w": "tsc -w"
3737
}
38-
}
38+
}

0 commit comments

Comments
 (0)