Merge pull request #5 from codepath/rogerh/add-timeout

Add connect and read timeout

Author: rogerhu

README.md

@@ -1,14 +1,14 @@
 # AsyncHttpClient library
 
-This is a lightweight asynchronous HTTP client powered by [OkHttp](https://square.github.io/okhttp/) but with a significantly simplified and easier to use API design.  
+This is a lightweight asynchronous HTTP client powered by [OkHttp](https://square.github.io/okhttp/) but with a significantly simplified and easier to use API design.
 
 The goal of this library is to have an API that clearly and cleanly supports the following features:
 
  * Asynchronous network requests without any need for manual thread handling
  * Response `onSuccess` callbacks run on the mainthread (by default)
  * Easy way to catch all errors and failures and handle them
  * Easy pluggable Text, JSON, and Bitmap response handlers to parse the response
- 
+
 This client tries to follow a similar API inspired by this [older now deprecated android-async-http library](https://github.com/android-async-http/android-async-http).
 
 ## Setup
@@ -17,7 +17,7 @@ To use this library, add the following to your `.gradle` file:
 
 ```gradle
 dependencies {
-  implementation 'com.codepath.libraries:asynchttpclient:2.0.1'
+  implementation 'com.codepath.libraries:asynchttpclient:2.1.0'
 }
 ```
 
@@ -30,29 +30,29 @@ dependencies {
     ```xml
     <manifest xmlns:android="http://schemas.android.com/apk/res/android"
                  package="com.codepath.example">
-       
+
            <uses-permission android:name="android.permission.INTERNET" />```
     ```
 
 3. Add any networking calls by leveraging the `AsyncHttpClient`
-   
+
    ```java
    AsyncHttpClient client = new AsyncHttpClient();
    client.get("https://api.thecatapi.com/v1/images/search", new TextHttpResponseHandler() {
        @Override
        public void onSuccess(int statusCode, Headers headers, String response) {
            Log.d("DEBUG", response);
        }
- 
+
        @Override
        public void onFailure(int statusCode, @Nullable Headers headers, String errorResponse, @Nullable Throwable throwable) {
            Log.d("DEBUG", errorResponse);
        }
    });
    ```
-   
-   This example uses `TextHttpResponseHandler` which presents the response as raw text. We could use the `JsonHttpResponseHandler` instead to have the API response automatically parsed for us into JSON. See [other example calls here](https://github.com/codepath/AsyncHttpClient/blob/master/example/src/main/java/com/codepath/example/TestActivity.java). 
-   
+
+   This example uses `TextHttpResponseHandler` which presents the response as raw text. We could use the `JsonHttpResponseHandler` instead to have the API response automatically parsed for us into JSON. See [other example calls here](https://github.com/codepath/AsyncHttpClient/blob/master/example/src/main/java/com/codepath/example/TestActivity.java).
+
 For more detailed usages, check out the [CodePath Async Http Client Guide](https://guides.codepath.com/android/Using-CodePath-Async-Http-Client).
 
 

build.gradle

@@ -7,7 +7,7 @@ buildscript {
 
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:4.0.1'
+        classpath 'com.android.tools.build:gradle:4.0.2'
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files
     }

example/build.gradle

@@ -26,10 +26,10 @@ android {
 
 dependencies {
     implementation fileTree(dir: 'libs', include: ['*.jar'])
-    implementation 'androidx.appcompat:appcompat:1.0.2'
-    implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
-    testImplementation 'junit:junit:4.12'
-    androidTestImplementation 'androidx.test:runner:1.2.0'
-    androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
+    implementation 'androidx.appcompat:appcompat:1.2.0'
+    implementation 'androidx.constraintlayout:constraintlayout:2.0.4'
+    testImplementation 'junit:junit:4.13.1'
+    androidTestImplementation 'androidx.test:runner:1.3.0'
+    androidTestImplementation 'androidx.test.espresso:espresso-core:3.3.0'
     implementation project(':library')
 }

example/src/main/java/com/codepath/example/TestActivity.java

@@ -57,6 +57,8 @@ public void onFailure(int statusCode, @Nullable Headers headers, String errorRes
             }
         });
 
+        client.setReadTimeout(10);
+        client.setConnectTimeout(10);
         RequestParams params = new RequestParams();
         params.put("limit", "5");
         params.put("page", 0);

library/build.gradle

@@ -11,7 +11,7 @@ ext {
     POM_DESC = "Async Http Client wrapper using OkHttp"
     POM_SCM_URL = 'https://github.com/codepath/AsyncHttpClient'
     BASE_VERSION = 2
-    VERSION_NAME = "2.0.1"
+    VERSION_NAME = "2.1.0"
 }
 
 version = VERSION_NAME
@@ -43,11 +43,11 @@ dependencies {
     implementation fileTree(dir: 'libs', include: ['*.jar'])
 
     implementation 'androidx.appcompat:appcompat:1.2.0'
-    api "com.squareup.okhttp3:okhttp:4.5.0"
+    api "com.squareup.okhttp3:okhttp:4.9.0"
     api 'com.facebook.stetho:stetho-okhttp3:1.5.1'
 
     testImplementation 'junit:junit:4.12'
-    androidTestImplementation 'androidx.test:runner:1.2.0'
+    androidTestImplementation 'androidx.test:runner:1.3.0'
     androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
 }
 

library/src/main/java/com/codepath/asynchttpclient/AsyncHttpClient.java

@@ -6,6 +6,7 @@
 
 import java.io.File;
 import java.util.Map;
+import java.util.concurrent.TimeUnit;
 
 import okhttp3.HttpUrl;
 import okhttp3.MediaType;
@@ -32,6 +33,14 @@ public AsyncHttpClient(OkHttpClient client) {
         okHttpClient = client;
     }
 
+    public void setReadTimeout(int timeout) {
+        okHttpClient.newBuilder().readTimeout(timeout, TimeUnit.SECONDS);
+    }
+
+    public void setConnectTimeout(int timeout) {
+        okHttpClient.newBuilder().connectTimeout(timeout, TimeUnit.SECONDS);
+    }
+
     protected Request.Builder createBuilderWithHeaders(
             String url, @Nullable RequestHeaders requestHeaders) {
         Request.Builder requestBuilder = new Request.Builder().url(url);