Skip to content

Commit a91b741

Browse files
authored
fix(artifactory): ignore extensions without a manifest (#69)
This ignores extensions where the manifest download from artifactory failed instead of crashing the process with a segfault. It fixes #68
1 parent 2da8330 commit a91b741

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

storage/artifactory.go

+4-1
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ func (s *Artifactory) WalkExtensions(ctx context.Context, fn func(manifest *VSIX
391391
return err
392392
} else if err != nil {
393393
id := ExtensionID(ext.publisher, ext.name, ext.versions[0].Version)
394-
s.logger.Error(ctx, "Unable to read extension manifest", slog.Error(err),
394+
s.logger.Error(ctx, "Unable to read extension manifest; extension will be ignored", slog.Error(err),
395395
slog.F("id", id),
396396
slog.F("targetPlatform", ext.versions[0].TargetPlatform))
397397
} else {
@@ -405,6 +405,9 @@ func (s *Artifactory) WalkExtensions(ctx context.Context, fn func(manifest *VSIX
405405
return err
406406
}
407407
for _, ext := range extensions {
408+
if ext.manifest == nil {
409+
continue
410+
}
408411
if err = fn(ext.manifest, ext.versions); err != nil {
409412
return err
410413
}

0 commit comments

Comments
 (0)