Skip to content

Git Graph extension empty #3774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vipwp opened this issue Jul 14, 2021 · 14 comments
Closed

Git Graph extension empty #3774

vipwp opened this issue Jul 14, 2021 · 14 comments
Labels
upstream:vscode Needs to be fixed upstream in VSCode waiting-for-info Waiting for more information from submitter

Comments

@vipwp
Copy link

vipwp commented Jul 14, 2021

OS/Web Information

  • Web Browser: Chrome/91.0.4472.77
  • Local OS: win 10
  • Remote OS: codercom/code-server:latest with docker 20.10.7 on centos 7.6
  • Remote Architecture: x86_64
  • code-server --version:3.10.2

Steps to Reproduce

  1. run container of codercom/code-server:latest
  2. install git graph extension (version:1.30.0)
  3. open git graph view

Expected

git history view

Actual

empty view

Logs

Screenshot

Notes

This issue can be reproduced in VS Code: Yes/No

@vipwp vipwp changed the title Git Graph extension Git Graph extension empty Jul 14, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 14, 2021

Hmm...I am not able to reproduce on Brave + macOS

Screenshot

image

Can you check if there are any logs in the browser?

Notes

We have had issues with this in the past:

@jsjoeio jsjoeio added the waiting-for-info Waiting for more information from submitter label Jul 14, 2021
@vipwp
Copy link
Author

vipwp commented Jul 14, 2021

Here's the errors in web debug console when opening the git graph tab.
image

http://{host}:8080/webview/out-vscode/vs/workbench/contrib/webview/browser/pre/main.js
http://{host}:8080/webview/out-vscode/vs/workbench/contrib/webview/browser/pre/host.js

No other errors in other logs.

@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 14, 2021

Hmm...I found this

In Chrome there is no built-in flag to disable service workers specifically. But service workers count as "cookies/site data" at chrome://settings/cookies so blocking those disables service worker.
Source

Are you disabling cookies by chance?

Actually wait do service workers work on http? What happens if you access your code-server instance on https?

@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 14, 2021

It seems like using https may solve the issue. See here

@vipwp
Copy link
Author

vipwp commented Jul 15, 2021

I upgrade the code-server to 3.11.0 but the extension still not work.
On https, I got this error on chrome when I open git graph tab.
image

this error on firefox
image

@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 15, 2021

Hmm... Do you know how we can enable service workers in your browser?

@vipwp
Copy link
Author

vipwp commented Jul 16, 2021

Hmm... Do you know how we can enable service workers in your browser?

Sorry I don't know.A document?

@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 19, 2021

What does your code-server setup look like? Where is it hosted?

@balesz
Copy link

balesz commented Jul 20, 2021

I think this issue is related: mhutchie/vscode-git-graph#535

@mateuszkitlas
Copy link

mateuszkitlas commented Jul 20, 2021

I think I have the same problem. I'm on code-server 3.10.2 and I'm developing my own extension. Sometimes (like 1 in 5 times) webviews just don't load leaving js script with host.js
obraz
obraz

This affects both webviews window.registerWebviewViewProvider and window.createWebviewPanel. I tried to detect this situation, then dispose() badly registered webview and register it again - but it does nothing.

Does this seem related? In my case no HTML is loaded.

@vipwp
Copy link
Author

vipwp commented Jul 20, 2021

What does your code-server setup look like? Where is it hosted?

The codeserver is installed in docker container(centos 7.2 x86_64) with code-server-3.11.0-linux-amd64.tar.gz.
The host info is: centos 7.6 x86_64

@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 20, 2021

I think this issue is related: mhutchie/vscode-git-graph#535

I think @balesz is right. Looks to be upstream in vscode. Might be worth raising an issue there. Here is a similar one: microsoft/vscode#127770

@jsjoeio jsjoeio added the upstream:vscode Needs to be fixed upstream in VSCode label Jul 20, 2021
@repo-ranger
Copy link
Contributor

repo-ranger bot commented Jul 20, 2021

This issue has been marked as 'upstream:vscode'. Please file this upstream: link to open issue
This issue will automatically close in 5 seconds.

@repo-ranger repo-ranger bot closed this as completed Jul 20, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 20, 2021

Closing for now, but I suggest opening upstream and/or subscribing to both the issue in git-graph and vscode. Let's hope they fix soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream:vscode Needs to be fixed upstream in VSCode waiting-for-info Waiting for more information from submitter
Projects
None yet
Development

No branches or pull requests

4 participants