Skip to content

[Bug]: Sign out available even with --auth none #5448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
code-asher opened this issue Aug 11, 2022 · 0 comments · Fixed by #5449
Closed
4 tasks done

[Bug]: Sign out available even with --auth none #5448

code-asher opened this issue Aug 11, 2022 · 0 comments · Fixed by #5449
Assignees
@code-asher
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer

Comments

@code-asher
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • code-server --version: 4.5.1

Steps to Reproduce

  1. run code-server --auth none
  2. open code-server
  3. observe logout menu option

Expected

No menu option

Actual

Menu option

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code or GitHub Codespaces?

  • I cannot reproduce this in VS Code.
  • I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

The check only sees if auth is defined when it should check that it is not none:

this._environmentService.args['auth'] ? base + '/logout' : undefined,
@code-asher code-asher added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Aug 11, 2022
@code-asher code-asher self-assigned this Aug 11, 2022
This was referenced Aug 11, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@code-asher code-asher

Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: logout appearing with auth=none code-asher/code-server
1 participant
@code-asher