chore: Clean up CI scripts

* Build with Go provided by GitHub instead of building inside
  a Dockerfile, which should speed up the build
* Condense build steps to avoid repeatedly downloading cached
  Go packages, which should speed up the build
* Run goimports using golangci-lint, rather than running
  gofmt and goimports manually in make fmt
* Skip signing/notarizing Darwin binary in build, since
  this takes a long time and is done in release
* Only build/test for pull requests against master
* Remove unnecessary steps in ci/image/Dockerfile
  * goimports is managed by golangci-lint
  * grep is already installed in the base image

Author: jawnsy

.github/workflows/build.yaml

@@ -1,5 +1,9 @@
 name: build
-on: [push]
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
 
 jobs:
   build:
@@ -19,20 +23,8 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v1
-      - name: Install Gon
-        run: |
-          brew tap mitchellh/gon
-          brew install mitchellh/gon/gon
-      - name: Import Signing Certificates
-        uses: Apple-Actions/import-codesign-certs@v1
-        with:
-          p12-file-base64: ${{ secrets.APPLE_DEVELOPER_CERTIFICATE_P12_BASE64 }}
-          p12-password: ${{ secrets.APPLE_DEVELOPER_CERTIFICATE_PASSWORD }}
       - name: Build
-        run: make build/macos
-        env:
-          AC_USERNAME: ${{ secrets.AC_USERNAME }}
-          AC_PASSWORD: ${{ secrets.AC_PASSWORD }}
+        run: unset CI && make build/macos
       - name: Upload
         uses: actions/upload-artifact@v2
         with:

.github/workflows/test.yaml

@@ -1,8 +1,12 @@
 name: test
-on: [push]
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
 
 jobs:
-  fmt:
+  staticcheck:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v1
@@ -12,20 +16,30 @@ jobs:
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
-      - name: fmt
-        uses: ./ci/image
+      - uses: actions/setup-go@v2
         with:
-          args: make -j fmt 
-      - run: ./ci/scripts/files_changed.sh
+          go-version: '^1.15.1' # The Go version to download (if necessary) and use.
+
+      - name: Ensure dependencies up-to-date
+        run: make fmt
+      - name: Check that "make fmt" is clean
+        run: ./ci/scripts/files_changed.sh
+
+      - name: Ensure documentation up-to-date
+        run: make gendocs
+      - name: Check that "make gendocs" is clean
+        run: ./ci/scripts/files_changed.sh
+
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - name: golangci-lint
+      - uses: actions/checkout@v1
+      - name: Run golangci-lint
         uses: golangci/golangci-lint-action@v2
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
           version: v1.29
+
   test:
     runs-on: ubuntu-latest
     steps:
@@ -40,18 +54,3 @@ jobs:
         uses: ./ci/image
         with:
           args: make -j test/go
-  gendocs:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v1
-      - uses: actions/cache@v1
-        with:
-          path: ~/go/pkg/mod
-          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
-          restore-keys: |
-            ${{ runner.os }}-go-
-      - name: generate-docs
-        uses: ./ci/image
-        with:
-          args: make -j gendocs
-      - run: ./ci/scripts/files_changed.sh

.golangci.yml

@@ -44,7 +44,7 @@ linters:
     - rowserrcheck
     - scopelint
     - goprintffuncname
-    - gofmt
+    - goimports
     - godot
     - ineffassign
     - gocritic

Makefile

@@ -20,11 +20,9 @@ build/linux:
 
 fmt:
 	go mod tidy
-	gofmt -w -s .
-	goimports -w "-local=$$(go list -m)" .
 
 lint:
-	golangci-lint run -c .golangci.yml
+	golangci-lint run
 
 gendocs:
 	rm -rf ./docs

ci/image/Dockerfile

@@ -3,6 +3,4 @@ FROM golang:1
 ENV GOFLAGS="-mod=readonly"
 ENV CI=true
 
-RUN go get golang.org/x/tools/cmd/goimports
 RUN go get github.com/mattn/goveralls
-RUN apt update && apt install grep