fix: Network error RTC race on flush

kylecarbs · kylecarbs · commit 2d16529b0719 · 2021-05-03T21:58:21.000Z
diff --git a/wsnet/rtc.go b/wsnet/rtc.go
@@ -171,9 +171,9 @@ func proxyICECandidates(conn *webrtc.PeerConnection, w io.Writer) func() {
 		if i == nil {
 			return
 		}
+		mut.Lock()
+		defer mut.Unlock()
 		if !flushed {
-			mut.Lock()
-			defer mut.Unlock()
 			queue = append(queue, i)
 			return
 		}

Original file line number	Diff line number	Diff line change
`@@ -171,9 +171,9 @@ func proxyICECandidates(conn *webrtc.PeerConnection, w io.Writer) func() {`
`171`	`171`	`if i == nil {`
`172`	`172`	`return`
`173`	`173`	`}`
	`174`	`+ mut.Lock()`
	`175`	`+ defer mut.Unlock()`
`174`	`176`	`if !flushed {`
`175`		`- mut.Lock()`
`176`		`- defer mut.Unlock()`
`177`	`177`	`queue = append(queue, i)`
`178`	`178`	`return`
`179`	`179`	`}`